-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sudo sfputil show error-status on a multiasic platform issue #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdosi
previously approved these changes
Oct 3, 2022
@mlok-nokia can we add code-coverage for same ? |
I am currently on some other task right now, can I add the code-coverage in the next PR? Thanks |
mlok-nokia
force-pushed
the
sfputil-show-error-status
branch
from
October 11, 2022 20:09
87e2db4
to
452bed5
Compare
@abdosi Unit Test case test_show_error_status() has been added for this PR. Please review it. Thanks. |
Signed-off-by: mlok <marty.lok@nokia.com>
mlok-nokia
force-pushed
the
sfputil-show-error-status
branch
from
October 24, 2022 17:42
452bed5
to
69d8af7
Compare
abdosi
approved these changes
Nov 2, 2022
7 tasks
yxieca
pushed a commit
that referenced
this pull request
Nov 10, 2022
Fixed "sudo sfputil show error-status" on a multiasic platform issue. Fixes sonic-net/sonic-buildimage#8504
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Nov 21, 2022
…ic-net#2373) Fixed "sudo sfputil show error-status" on a multiasic platform issue. Fixes sonic-net/sonic-buildimage#8504
mdanish-kh
pushed a commit
to mdanish-kh/sonic-utilities
that referenced
this pull request
Nov 23, 2022
…ic-net#2373) Fixed "sudo sfputil show error-status" on a multiasic platform issue. Fixes sonic-net/sonic-buildimage#8504
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixed "sudo sfputil show error-status" on a multiasic platform issue. Fixes sonic-net/sonic-buildimage#8504
This change is also applicable to 202205 branch
How I did it
The current implementation is only hard code to connect STATE_DB on host database with SonicV2Connector(127.,0.0.1). To support the multiasic platform, we need to query the data entry from STATE_DB of namespace database. Following the existing design to use multi_asic.get_front_end_namespaces. And looping the namespaces to get the output_table for each namespace.
How to verify it
Previous command output (if the output of a command-line utility has changed)
Previous output doesn't have any port name
New command output (if the output of a command-line utility has changed)