Add fast-reboot support for Aboot based images #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
reviewed
Mar 2, 2018
sonic_installer/main.py
Outdated
| @@ -184,7 +184,7 @@ def install(url): | |||
|
|
|||
| if get_image_type() == IMAGE_TYPE_ABOOT: | |||
| run_command("/usr/bin/unzip -od /tmp %s boot0" % image_path) | |||
| run_command("swipath=%s target_path=/host sonic_upgrade=1 . /tmp/boot0" % image_path) | |||
| run_command("swipath=%s target_path=/host install=y . /tmp/boot0" % image_path) | |||
There was a problem hiding this comment.
are you going to change boot0.j2 in sonic-buildimage to support install option? current I only see sonic_upgrade there.
There was a problem hiding this comment.
you do not really need to change to install=y. keep it as it is is better, so that we can merge your PR without the boot0.j2 change. there is no coordination, otherwise, we need to coordinate this PR with the boot0.j2 PR.
There was a problem hiding this comment.
I was planning on the pull request on sonic-buildimage that bumps the sonic-utilities and adds the boot0.j2 change as soon as this one merged.
But you are correct I can leave the sonic_upgrade=1 as it is. Will update this PR.
prsunny
approved these changes
Mar 2, 2018
Staphylo
force-pushed
the
aboot-fast-reboot
branch
from
122ae7d to
4271417
Compare
SAI-shared-user
approved these changes
Mar 2, 2018
zhenggen-xu
added a commit
to zhenggen-xu/sonic-utilities
that referenced
this pull request
Jun 6, 2018
RB=1288101
G=lnos-reviewers
R=ntrianta,pmao,rmolina,sfardeen,zxu
* github:
[acl_loader] Support Service ACL binding to multiple services (sonic-net#236)
[show] Rename 'show session' to 'show mirror session' (sonic-net#235)
[pfcstat]: create python cli tool to show pfc counters (sonic-net#233)
[queuestat] add python CLI tool to show queue counters
[acl-loader] Not to crash upon invalid rule (sonic-net#232)
Show FDB type in fdbshow/show mac (sonic-net#231)
[show] add 'show runningconfiguration all' subcommand (sonic-net#230)
[reboot scripts] remove -t option in docker exec commands (sonic-net#228)
[reboot] reduce stop service to only stop syncd (sonic-net#223)
[crm]: Fix failures in CLI show commands (sonic-net#221)
[Fast-reboot]: Gracefully shutdown syncd in fast-reboot (sonic-net#212)
add fast-reboot support for nephos platform by stop kernel modules (sonic-net#220)
[config bgp] Convert user input ipv6 addr to lower case before comparing (sonic-net#218)
[PFCWD]: set default configuration when enabled by default (sonic-net#213)
Add fast-reboot support for Aboot based images (sonic-net#214)
sonic-utilities: Format show vlan config output (sonic-net#210)
[AAA] Support login(ascii) authentication type (sonic-net#217)
[sfputil] Adapt new way of getting PLATFORM(sonic-net#216)
[Fast-Reboot]: Adapt fast-reboot-dump script for SAIv1.2 (sonic-net#211)
Refactor fast-reboot script. Generate fast-reboot-dumps into configurable directory (sonic-net#208)
Find correct opennsl module name before stopping it (sonic-net#207)
[crm]: Add utility for CRM configuration (sonic-net#187)
[reboot] update reboot script to retrieve platform with new format (sonic-net#206)
Adapt to config engine change to load platform info properly (sonic-net#205)
[config] Add qos clear and qos reload support (sonic-net#204)
Dump default routes from APPL_DB table before fast-reboot (sonic-net#203)
[acl_loader] Fix a crash issue when appdb is not consistent with cfgdb (sonic-net#202)
[pfcwd]: add command to set pfcwd polling interval (sonic-net#192)
[acl-loader] Prevent from hanging if run by non-root user (sonic-net#199)
[config] Store ConfigDB init indicator boolean value as 1/0 in Redis to be language-agnostic (sonic-net#197)
Get Vlan Id from SAI Vlan Object if bvid present (sonic-net#196)
[TACACS+]: Fix aaa show error without configuration (sonic-net#191)
'config bgp [shutdown|startup] neighbor <hostname>' now affects all sessions for neighbor (sonic-net#195)
[sonic-clear] add a clear fdb command (sonic-net#186)
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
Signed-off-by: Prince George <prgeor@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added support of fast-reboot for Arista platform by adding support of Aboot in fast-reboot.
Also changed sonic_installer to use
install=yinstead ofsonic_upgrade=1.The boot0 will stay backward compatible with previous
sonic_installerversions.- How to verify it
Running
sonic_installer installand thenfast-rebootshould show kexec working.It is assumed that all ONIE based platform define onie_platform= in /host/machine.conf.