Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system-health] Remove booting stage in system health service #2022

Merged

Conversation

Junchao-Mellanox
Copy link
Collaborator

What I did

For SYSTEM READY feature. Currently, there is a booting stage in system health service to indicate that the system is loading SONiC component. This booting stage is no longer needed because SYSTEM READY feature will treat that stage as system "NOT READY".

How I did it

  1. Remove booting stage
  2. Adjust unit test cases

How to verify it

  1. Manual test
  2. Unit test
  3. sonic-mgmt Regression

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@sg893052
Copy link
Contributor

Looks fine.
As per system ready, the operational data(service status and appready status) will be stored in STATE_DB.
We may have to come up with an option in the CLI to show the services and its status to fetch the data from STATE_DB.

Copy link
Collaborator

@liat-grozovik liat-grozovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved following the reviewers approval

@liat-grozovik liat-grozovik merged commit c652ad0 into sonic-net:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants