Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[202012] [generate_dump] allow to extend dump with plugin scripts #1945

Merged
merged 3 commits into from
Dec 9, 2021
Merged

[202012] [generate_dump] allow to extend dump with plugin scripts #1945

merged 3 commits into from
Dec 9, 2021

Conversation

noaOrMlnx
Copy link
Collaborator

Signed-off-by: Noa Or noaor@nvidia.com

What I did

Added support for tech support extension scripts,
by cherry-picking of #1335 to branch 202012

The purpose is to have dumps of extensions in SONiC techsupport, even without App Extension infrastructure.
The new application will write a file that contains the dump command into /usr/bin/debug-dump folder, and it will appear in the output of show techsupport command.

How I did it

It looks at /usr/bin/debug-dump for scripts, if it finds one it will execute them and save the output to dump/ folder.

How to verify it

Write a simple scripts that outputs something and place it under /usr/bin/debug-dump/

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

stepanblyschak and others added 3 commits November 21, 2021 15:02
@stepanblyschak @noaOrMlnx
[generate_dump] enhance plugin handling
7bb5f84 
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
@stepanblyschak @noaOrMlnx
[generate_dump] enhance plugin handling
3b77cce 
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
@noaOrMlnx
Merge branch '202012-techsupport' of github.com:noaOrMlnx/sonic-utili…
63b7f00 
…ties into 202012-techsupport
@liat-grozovik
Copy link
Collaborator

@qiluo-msft could you please help to review?

@noaOrMlnx
Copy link
Collaborator Author

@qiluo-msft
A kind reminder

@qiluo-msft qiluo-msft merged commit 44ec4c8 into sonic-net:202012 Dec 9, 2021
@stephenxs stephenxs mentioned this pull request Dec 14, 2021
Merged
5 tasks
@stephenxs
Copy link
Collaborator

@noaOrMlnx With this PR merged, there are the following errors:

2021-12-15T21:00:30.1409842Z         # Raise exception if host(s) unreachable
2021-12-15T21:00:30.1410931Z         # FIXME - if multiple hosts were involved, should an exception be raised?
2021-12-15T21:00:30.1411322Z         if cb.unreachable:
2021-12-15T21:00:30.1411888Z >           raise AnsibleConnectionFailure("Host unreachable", dark=cb.unreachable, contacted=cb.contacted)
2021-12-15T21:00:30.1412379Z E           AnsibleConnectionFailure: Host unreachable

Check kvm t0 and kvm t1-lag for details.

@liat-grozovik
Copy link
Collaborator

liat-grozovik commented Dec 17, 2021 via email

@noaOrMlnx
Copy link
Collaborator Author

@stephenxs
Hi,
the new cherry-pick goes into debug-dump folder and execute commands from the files we have in there.
since we don't have plugin folder in kvm, I think this change cannot be caused from my change.

please retrigger and update, thanks!

stephenxs added a commit to stephenxs/sonic-buildimage that referenced this pull request Dec 22, 2021
@stephenxs
[sonic-utilities] Submodule update
27761ac 
44ec4c8b [202012] [generate_dump] allow to extend dump with plugin scripts (sonic-net/sonic-utilities#1945)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs stephenxs mentioned this pull request Dec 22, 2021
Closed
5 tasks
@stephenxs
Copy link
Collaborator

@stephenxs Hi, the new cherry-pick goes into debug-dump folder and execute commands from the files we have in there. since we don't have plugin folder in kvm, I think this change cannot be caused from my change.

please retrigger and update, thanks!

A draft PR has been created for dry run: sonic-net/sonic-buildimage#9617

noaOrMlnx added a commit to noaOrMlnx/sonic-utilities that referenced this pull request Dec 30, 2021
@noaOrMlnx
Revert "[202012] [generate_dump] allow to extend dump with plugin scr…
927c960 
…ipts (sonic-net#1945)"

This reverts commit 44ec4c8.
@noaOrMlnx noaOrMlnx mentioned this pull request Dec 30, 2021
Merged
liat-grozovik pushed a commit that referenced this pull request Dec 30, 2021
@noaOrMlnx
Revert "[202012] [generate_dump] allow to extend dump with plugin scr…
466807e 
…ipts (#1945)" (#1993)

This reverts commit 44ec4c8.

- What I did

revert "[202012] [generate_dump] allow to extend dump with plugin scripts (#1945)" commit

- How I did it
N/A

- How to verify it
N/A
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 18, 2022
@dprital
[202012] [submodule] Update sonic-utilities submodule (#9661)
1eec2bc 
Update submodule sonic-utilities that contains the following commits:

Revert "[202012] [generate_dump] allow to extend dump with plugin scripts (sonic-net#1945)" (sonic-net#1993)
[soft-reboot] Add support for platforms based on Device Tree (sonic-net#1963)
[Reclaiming buffer][202012] Database migrator for reclaiming buffer (sonic-net#1898)
[202012] [generate_dump] allow to extend dump with plugin scripts (sonic-net#1945)

Signed-off-by: dprital <drorp@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@stepanblyschak stepanblyschak stepanblyschak approved these changes

Assignees
No one assigned
Labels
Request for 201911 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@noaOrMlnx @liat-grozovik @stephenxs @qiluo-msft @stepanblyschak