[voq] Add fabric counter cli commands #1860

mlorrillere · 2021-10-06T18:27:56Z

Add fabric counters CLI commands.

Commands are:
show fabric counters port
show fabric counters port -n asic4
show fabric counters port -n asic5 -e
show fabric counters queue
show fabric counters queue -n asic4

Signed-off-by: Maxime Lorrillere mlorrillere@arista.com

New command output (if the output of a command-line utility has changed)

# fabricstat -h
usage: fabricstat [-h] [-q] [-n NAMESPACE] [-e]

Display the fabric port state and counters

optional arguments:
  -h, --help            show this help message and exit
  -q, --queue           Display fabric queue stat, otherwise port stat
  -n NAMESPACE, --namespace NAMESPACE
                        Display fabric ports for specific namespace
  -e, --errors          Display errors

Examples:
    fabricstat
    fabricstat --namespace asic0
    fabricstat -p -n asic0 -e
    fabricstat -q
    fabricstat -q -n asic0

# show fabric counters -h
Usage: show fabric counters [OPTIONS] COMMAND [ARGS]...

  Show fabric port counters

Options:
  -h, -?, --help  Show this message and exit.

Commands:
  port   Show fabric port stat
  queue  Show fabric queue stat

# show fabric counters port -h
Usage: show fabric counters port [OPTIONS]

  Show fabric port stat

Options:
  -d, --display [all|frontend]    Show internal interfaces  [default:
                                  frontend]
  -n, --namespace [asic0|asic1|asic2|asic3|asic4|asic5|asic6|asic7|asic8|asic9|asic10|asic11]
                                  Namespace name or all
  -e, --errors
  -h, -?, --help                  Show this message and exit.

Example output:

# show fabric counters port -n asic0
  ASIC    PORT    STATE    IN_CELL    IN_OCTET    OUT_CELL    OUT_OCTET    CRC    FEC_CORRECTABLE    FEC_UNCORRECTABLE    SYMBOL_ERR
------  ------  -------  ---------  ----------  ----------  -----------  -----  -----------------  -------------------  ------------
     0       0     down          0           0           0            0      0             206318           7949306448             0
     0       1     down          0           0           0            0      0                  0           7949048925             0
     0       2     down          0           0           0            0      0                  0           7948552578             0
     0       3     down          0           0           0            0      0                  0           7948049934             0
     0       4     down          0           0           0            0      0                  0           7947524845             0
     0       5     down          0           0           0            0      0                  0           7946976870             0
     0       6     down          0           0           0            0      0                  0           7946408318             0
     0       7     down          0           0           0            0      0                  0           7945775522             0
[...]
     0     187     down          0           0           0            0   3024         6887370202              3773897   11545823075
     0     188     down          0           0           0            0      0                  0          13130704211             0
     0     189     down          0           0           0            0      0             118941          13129730022             0
     0     190       up          0           0           0            0    514          162556197           2717957083          4823
     0     191     down          0           0           0            0      0                  0          13128089835             0

lgtm-com · 2021-10-06T18:37:41Z

This pull request introduces 4 alerts when merging b1a7aa9a9decd643905fc76fe3c0e8ac656473ca into 88baf3d - view on LGTM.com

new alerts:

3 for Unused import
1 for Syntax error

lgtm-com · 2021-10-06T18:57:21Z

This pull request introduces 7 alerts when merging 5c25eb1fc39333aa51318bd53f3ef22ee5f91461 into 88baf3d - view on LGTM.com

new alerts:

6 for Unused import
1 for Unused local variable

mlorrillere · 2021-10-20T16:15:44Z

IN_CELL might not be required since we have IN_OCTET

mlorrillere · 2021-10-20T16:17:47Z

Rename port to lane

mlorrillere · 2021-10-20T16:19:10Z

Can we output a neighbor partner for a given link?

rlhui · 2021-10-20T17:28:38Z

@skeesara-nokia, @vganesan-nokia - please help review, thanks

vganesan-nokia

Please address review comments

show/fabric.py

scripts/fabricstat

lgtm-com · 2021-11-25T01:05:07Z

This pull request introduces 9 alerts when merging a53b193ab9917286fe918c6f51dc7ccf0be5ae80 into c05845d - view on LGTM.com

new alerts:

8 for Unused import
1 for Unused local variable

lgtm-com · 2021-11-25T01:50:36Z

This pull request introduces 9 alerts when merging c8cc5c78c9aaef24e7fe087894e99ed04937a59a into c05845d - view on LGTM.com

new alerts:

8 for Unused import
1 for Unused local variable

arlakshm · 2021-12-14T20:17:30Z

This pull request introduces 9 alerts when merging c8cc5c7 into c05845d - view on LGTM.com

new alerts:

8 for Unused import

1 for Unused local variable

@mlorrillere can you fix the lgtm alerts?

arlakshm · 2021-12-14T20:21:01Z

This pull request introduces 9 alerts when merging c8cc5c7 into c05845d - view on LGTM.com

new alerts:

8 for Unused import

1 for Unused local variable

@mlorrillere can you fix the lgtm alerts?

mlorrillere · 2021-12-14T21:40:28Z

This pull request introduces 9 alerts when merging c8cc5c7 into c05845d - view on LGTM.com
new alerts:

8 for Unused import

1 for Unused local variable

@mlorrillere can you fix the lgtm alerts?

My bad, I had the changes ready and forgot to commit. Should be fixed now.

arlakshm · 2022-05-04T19:41:01Z

Hi @mlorrillere, the unit tests added for the fabric counter, tests/fabricstat_test.py, are failing.
I think the reason they are failing is because the tests are trying to connect to the actual redis instance iso for mock db.
the script fabricstat the mock db must if the UTILITIES_UNIT_TESTING enivornment variable is set.

Please refer to this block as an example https://github.com/Azure/sonic-utilities/blob/master/scripts/intfutil#L15-L28

mlorrillere · 2022-06-21T18:49:36Z

Hi @arlakshm

I've addressed the remaining issues and all checks passed.

Signed-off-by: Maxime Lorrillere <mlorrillere@arista.com>

linux-foundation-easycla · 2022-08-02T17:41:50Z

The committers listed above are authorized under a signed CLA.

✅ login: mlorrillere / name: Maxime Lorrillere (98b3c2a)

mlorrillere · 2022-08-02T21:32:15Z

/easycla

arlakshm · 2022-09-10T00:03:56Z

/Azp run Azure.sonic-utilities

azure-pipelines · 2022-09-10T00:04:05Z

Azure Pipelines successfully started running 1 pipeline(s).

kenneth-arista · 2022-10-17T18:39:57Z

@arlakshm since everything is approved, can you merge this PR?

Add fabric counters CLI commands. Commands are: show fabric counters port show fabric counters port -n asic4 show fabric counters port -n asic5 -e show fabric counters queue show fabric counters queue -n asic4 Signed-off-by: Maxime Lorrillere <mlorrillere@arista.com>

mlorrillere mentioned this pull request Oct 6, 2021

[fabricportsorch] Collect counters for fabric links sonic-net/sonic-swss#1944

Merged

mlorrillere force-pushed the pr-fabric-counters branch from b1a7aa9 to 5c25eb1 Compare October 6, 2021 18:46

mlorrillere force-pushed the pr-fabric-counters branch from 5c25eb1 to 2f6d15d Compare October 6, 2021 19:03

rlhui requested review from arlakshm and abdosi October 20, 2021 17:29

mlorrillere force-pushed the pr-fabric-counters branch from 2f6d15d to 6d29da2 Compare October 25, 2021 22:53

vganesan-nokia suggested changes Oct 27, 2021

View reviewed changes

show/fabric.py Outdated Show resolved Hide resolved

scripts/fabricstat Outdated Show resolved Hide resolved

scripts/fabricstat Outdated Show resolved Hide resolved

scripts/fabricstat Show resolved Hide resolved

arlakshm requested changes Nov 11, 2021

View reviewed changes

scripts/fabricstat Show resolved Hide resolved

scripts/fabricstat Outdated Show resolved Hide resolved

rlhui assigned arlakshm Nov 16, 2021

mlorrillere force-pushed the pr-fabric-counters branch 2 times, most recently from 490acd4 to a53b193 Compare November 25, 2021 00:53

mlorrillere force-pushed the pr-fabric-counters branch from a53b193 to c8cc5c7 Compare November 25, 2021 01:33

mlorrillere force-pushed the pr-fabric-counters branch from c8cc5c7 to 2f051bf Compare December 14, 2021 21:39

mlorrillere force-pushed the pr-fabric-counters branch from 2f051bf to 7357ae1 Compare February 16, 2022 22:55

mlorrillere requested a review from arlakshm April 12, 2022 20:30

rlhui added the Chassis label Apr 12, 2022

mlorrillere force-pushed the pr-fabric-counters branch from 7357ae1 to 214b008 Compare April 20, 2022 16:50

mlorrillere force-pushed the pr-fabric-counters branch from 214b008 to dcdda12 Compare April 27, 2022 17:44

mlorrillere force-pushed the pr-fabric-counters branch 5 times, most recently from 4863631 to 38a3d50 Compare June 21, 2022 18:28

Add fabric counter cli commands

98b3c2a

Signed-off-by: Maxime Lorrillere <mlorrillere@arista.com>

mlorrillere force-pushed the pr-fabric-counters branch from 38a3d50 to 98b3c2a Compare August 2, 2022 17:41

arlakshm approved these changes Sep 12, 2022

View reviewed changes

arlakshm added the Request for 202205 Branch label Oct 17, 2022

arlakshm merged commit 25fda26 into sonic-net:master Oct 17, 2022

yxieca added the Included in 202205 Branch label Oct 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[voq] Add fabric counter cli commands #1860

[voq] Add fabric counter cli commands #1860

mlorrillere commented Oct 6, 2021

lgtm-com bot commented Oct 6, 2021

lgtm-com bot commented Oct 6, 2021

mlorrillere commented Oct 20, 2021 •

edited

Loading

mlorrillere commented Oct 20, 2021

mlorrillere commented Oct 20, 2021

rlhui commented Oct 20, 2021

vganesan-nokia left a comment

lgtm-com bot commented Nov 25, 2021

lgtm-com bot commented Nov 25, 2021

arlakshm commented Dec 14, 2021

arlakshm commented Dec 14, 2021

mlorrillere commented Dec 14, 2021

arlakshm commented May 4, 2022

mlorrillere commented Jun 21, 2022

linux-foundation-easycla bot commented Aug 2, 2022 •

edited

Loading

mlorrillere commented Aug 2, 2022

arlakshm commented Sep 10, 2022

azure-pipelines bot commented Sep 10, 2022

kenneth-arista commented Oct 17, 2022

[voq] Add fabric counter cli commands #1860

[voq] Add fabric counter cli commands #1860

Conversation

mlorrillere commented Oct 6, 2021

New command output (if the output of a command-line utility has changed)

lgtm-com bot commented Oct 6, 2021

lgtm-com bot commented Oct 6, 2021

mlorrillere commented Oct 20, 2021 • edited Loading

mlorrillere commented Oct 20, 2021

mlorrillere commented Oct 20, 2021

rlhui commented Oct 20, 2021

vganesan-nokia left a comment

Choose a reason for hiding this comment

lgtm-com bot commented Nov 25, 2021

lgtm-com bot commented Nov 25, 2021

arlakshm commented Dec 14, 2021

arlakshm commented Dec 14, 2021

mlorrillere commented Dec 14, 2021

arlakshm commented May 4, 2022

mlorrillere commented Jun 21, 2022

linux-foundation-easycla bot commented Aug 2, 2022 • edited Loading

mlorrillere commented Aug 2, 2022

arlakshm commented Sep 10, 2022

azure-pipelines bot commented Sep 10, 2022

kenneth-arista commented Oct 17, 2022

mlorrillere commented Oct 20, 2021 •

edited

Loading

linux-foundation-easycla bot commented Aug 2, 2022 •

edited

Loading