Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202012] [portstat pfcstat] Unify the packet number format in the output of portstat and pfcstat in all cases #1795

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

keboliu
Copy link
Collaborator

@keboliu keboliu commented Sep 2, 2021

What I did

backport #1755 to 202012 branch

How I did it

Add a new function format_number_with_comma to format the packet numbers with comma, this function will be called in case ns_diff is not applicable.

Update the unitest to cover this new change.

How to verify it

execute portstat and pfcstat to check the output whether the number format is expected.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@qiluo-msft qiluo-msft merged commit 0e0478b into sonic-net:202012 Sep 3, 2021
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 18, 2022
* d03ba4f [202012] [portstat, intfstat] added rates and utilization  (sonic-net#1812)
* 499ad3f [config reload] Fix config reload failure due to sonic.target job cancellation (sonic-net#1814)
* 96d658c [202012][sonic installer] Add swap setup support (sonic-net#1815)
* a9c6970 platform pre-check for reboot in 202012 branch (sonic-net#1788)
* 0e0478b Unify the number format in the ourput of portstat and pfcstat in all cases (sonic-net#1795)
* 2d1e00e [ecnconfig] Fix exception seen during display and add unit tests (sonic-net#1784) (sonic-net#1789)

Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
@keboliu keboliu deleted the 202012-counter-format-fix branch October 28, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants