Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci]: add vstest #1436

Merged
merged 8 commits into from
Mar 29, 2021
Merged

[ci]: add vstest #1436

merged 8 commits into from
Mar 29, 2021

Conversation

lguohan
Copy link
Contributor

@lguohan lguohan commented Feb 13, 2021

Signed-off-by: Guohan Lu lguohan@gmail.com

What I did

add vstest

How I did it

How to verify it

pr

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

azure-pipelines.yml Outdated Show resolved Hide resolved
@lguohan
Copy link
Contributor Author

lguohan commented Feb 17, 2021

@jleveque , can you review this pr again?

jleveque
jleveque previously approved these changes Feb 17, 2021
Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but tests are failing. Is this expected?

Signed-off-by: Guohan Lu <lguohan@gmail.com>
Signed-off-by: Guohan Lu <lguohan@gmail.com>
Signed-off-by: Guohan Lu <lguohan@gmail.com>
Signed-off-by: Guohan Lu <lguohan@gmail.com>
Signed-off-by: Guohan Lu <lguohan@gmail.com>
Signed-off-by: Guohan Lu <lguohan@gmail.com>
Signed-off-by: Guohan Lu <lguohan@gmail.com>
Signed-off-by: Guohan Lu <lguohan@gmail.com>
@lguohan
Copy link
Contributor Author

lguohan commented Mar 29, 2021

vstest passed. @jleveque , can you approve?

@lguohan
Copy link
Contributor Author

lguohan commented Mar 29, 2021

retest this please

@jleveque jleveque added the CI label Mar 29, 2021
@lguohan lguohan merged commit 6b51bcd into sonic-net:master Mar 29, 2021
xumia pushed a commit to xumia/sonic-utilities that referenced this pull request Jun 28, 2021
Signed-off-by: Guohan Lu <lguohan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants