[config][show] cli support for retrieving ber, eye-info and configuring prbs, loopback on Y-cable #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eye info, configure prbs and loopback Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
jleveque
suggested changes
Jan 26, 2021
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
jleveque
reviewed
Jan 27, 2021
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
jleveque
reviewed
Jan 27, 2021
show/muxcable.py
Outdated
|
|
||
| if os.geteuid() != 0: | ||
| click.echo("Root privileges are required for this operation") | ||
| sys.exit(CONFIG_FAIL) |
There was a problem hiding this comment.
CONFIG_SUCCESSFUL / CONFIG_FAIL names don't really apply to the show command, as nothing is being configured. Can we change them to EXIT_SUCCESS and EXIT_FAILURE, or similar? And what is the difference between the CONFIG_* values and the STATUS_* codes?
There was a problem hiding this comment.
fixed. changed these to EXIT_FAILURE . Actually all these error codes require rework now that I read your comment. Originally i wrote STATUS_ and CONFIG_ to differentiate between
show muxcable status and
show muxcable config but they are confusing as we are not configuring everything in config. But hwproxy now already has the error codes handed over. Maybe just rename them and keep the codes(integer value) as is ?
4 tasks
jleveque
added a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jan 28, 2021
**- Why I did it** sonic-utilities will become dependent upon sonic-platform-common as of sonic-net/sonic-utilities#1386. **- How I did it** - Add sonic-platform-common as a dependency in docker-sonic-vs.mk - Additionally, no longer install Python 2 packages of swsssdk and sonic-py-common, as they should no longer be needed.
|
Restest this please |
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
jleveque
suggested changes
Feb 1, 2021
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
jleveque
suggested changes
Feb 3, 2021
lguohan
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Feb 3, 2021
**- Why I did it** sonic-utilities will become dependent upon sonic-platform-common as of sonic-net/sonic-utilities#1386. **- How I did it** - Add sonic-platform-common as a dependency in docker-sonic-vs.mk - Additionally, no longer install Python 2 packages of swsssdk and sonic-py-common, as they should no longer be needed.
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
jleveque
suggested changes
Feb 3, 2021
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
jleveque
suggested changes
Feb 3, 2021
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
jleveque
suggested changes
Feb 3, 2021
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
jleveque
previously approved these changes
Feb 4, 2021
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
|
Retest this please |
deran1980
pushed a commit
to deran1980/sonic-buildimage
that referenced
this pull request
Feb 4, 2021
**- Why I did it** sonic-utilities will become dependent upon sonic-platform-common as of sonic-net/sonic-utilities#1386. **- How I did it** - Add sonic-platform-common as a dependency in docker-sonic-vs.mk - Additionally, no longer install Python 2 packages of swsssdk and sonic-py-common, as they should no longer be needed.
jleveque
approved these changes
Feb 4, 2021
daall
pushed a commit
that referenced
this pull request
Feb 6, 2021
…ng prbs, loopback on Y-cable (#1386) This PR provides the support for adding CLI commands for configuring prbs, loopback and showing the BER and Eye info of the muxcable. In particular these Cli commands are supported: ` show muxcable eyeinfo <portnumber><target>` ` show muxcable berinfo <portnumber> <target>` `config muxcable prbs <portnumber> <target> <mode> <lanemap>` `config muxcable loopback <portnumber> <target> <lanemap>` #### What is the motivation for this PR? To add the support for Cli for muxcable to be utilized for configuring prbs, loopback modes and showing the ber, eye info of all the Port/Ports on a muxcable. Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
4 tasks
lguohan
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Feb 6, 2021
sonic-utilities will become dependent upon sonic-platform-common as of sonic-net/sonic-utilities#1386.
anand-kumar-subramanian
pushed a commit
to anand-kumar-subramanian/sonic-utilities
that referenced
this pull request
Mar 2, 2021
…ng prbs, loopback on Y-cable (sonic-net#1386) This PR provides the support for adding CLI commands for configuring prbs, loopback and showing the BER and Eye info of the muxcable. In particular these Cli commands are supported: ` show muxcable eyeinfo <portnumber><target>` ` show muxcable berinfo <portnumber> <target>` `config muxcable prbs <portnumber> <target> <mode> <lanemap>` `config muxcable loopback <portnumber> <target> <lanemap>` #### What is the motivation for this PR? To add the support for Cli for muxcable to be utilized for configuring prbs, loopback modes and showing the ber, eye info of all the Port/Ports on a muxcable. Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
lguohan
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Mar 13, 2021
sonic-utilities will become dependent upon sonic-platform-common as of sonic-net/sonic-utilities#1386.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR provides the support for adding CLI commands for configuring prbs, loopback and showing the BER and Eye info of the muxcable.
In particular these Cli commands are supported:
show muxcable eyeinfo <portnumber><target>show muxcable berinfo <portnumber> <target>config muxcable prbs <portnumber> <target> <mode> <lanemap>config muxcable loopback <portnumber> <target> <lanemap>Type of change
Approach
added the changes in sonic-utilities/show and sonic-utilities/config by changing the muxcable.py
What is the motivation for this PR?
To add the support for Cli for muxcable to be utilized for configuring prbs, loopback modes and showing the ber, eye info of all the Port/Ports on a muxcable.
How did you do it?
Added the changes inside sonic-utilities and tested it on the testbed
How did you verify/test it?
Ran the cli commands on an Arista7260cx3 testbed with Gemini cable
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com