[show] Fix int status when portchannel is in the system #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: d-dashkov <Dmytro_Dashkov@Jabil.com>
d-dashkov
changed the title
|
retest this please |
Signed-off-by: d-dashkov <Dmytro_Dashkov@Jabil.com>
lguohan
approved these changes
Feb 4, 2021
judyjoseph
approved these changes
Feb 4, 2021
daall
pushed a commit
that referenced
this pull request
Feb 6, 2021
* Fixed int stat with portchannel
* Replace N/A with None
Fixed crash of "show int status" command when there are portchannels in system.
Traceback (most recent call last):
File "/usr/local/bin/intfutil", line 521, in <module>
main()
File "/usr/local/bin/intfutil", line 513, in main
interface_stat.display_intf_status()
File "/usr/local/bin/intfutil", line 354, in display_intf_status
self.get_intf_status()
File "/usr/local/lib/python3.7/dist-packages/utilities_common/multi_asic.py", line 137, in wrapped_run_on_all_asics
func(self, *args, **kwargs)
File "/usr/local/bin/intfutil", line 435, in get_intf_status
self.portchannel_speed_dict = po_speed_dict(self.po_int_dict, self.db)
File "/usr/local/bin/intfutil", line 249, in po_speed_dict
interface_speed = '{}G'.format(interface_speed[:-3])
TypeError: 'NoneType' object is not subscriptable
Signed-off-by: d-dashkov <Dmytro_Dashkov@Jabil.com>
anand-kumar-subramanian
pushed a commit
to anand-kumar-subramanian/sonic-utilities
that referenced
this pull request
Mar 2, 2021
* Fixed int stat with portchannel
* Replace N/A with None
Fixed crash of "show int status" command when there are portchannels in system.
Traceback (most recent call last):
File "/usr/local/bin/intfutil", line 521, in <module>
main()
File "/usr/local/bin/intfutil", line 513, in main
interface_stat.display_intf_status()
File "/usr/local/bin/intfutil", line 354, in display_intf_status
self.get_intf_status()
File "/usr/local/lib/python3.7/dist-packages/utilities_common/multi_asic.py", line 137, in wrapped_run_on_all_asics
func(self, *args, **kwargs)
File "/usr/local/bin/intfutil", line 435, in get_intf_status
self.portchannel_speed_dict = po_speed_dict(self.po_int_dict, self.db)
File "/usr/local/bin/intfutil", line 249, in po_speed_dict
interface_speed = '{}G'.format(interface_speed[:-3])
TypeError: 'NoneType' object is not subscriptable
Signed-off-by: d-dashkov <Dmytro_Dashkov@Jabil.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fixed crash of "show int status" command when there are portchannels in system.
fixes sonic-net/sonic-buildimage#6520
Also this might fix this issue:
fixes #1082
- How I did it
Added check of return value from db in inftutil.
If value is None, append N/A to the output instead of formatting incorrect type.
- How to verify it
$ sudo config portchannel add PortChannel0011
$ show int status
Signed-off-by: d-dashkov Dmytro_Dashkov@Jabil.com