Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[acl-loader] Make list sorting compliant with Python 3 #1257

Merged
merged 1 commit into from
Nov 20, 2020
Merged

[acl-loader] Make list sorting compliant with Python 3 #1257

merged 1 commit into from
Nov 20, 2020

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented Nov 20, 2020 •
edited
Loading

In Python 3, sort() takes no positional arguments, only keyword arguments. Fix acl-loader to comply.

Fixes vsimage build failure in sonic-net/sonic-buildimage#5926

@jleveque jleveque self-assigned this Nov 20, 2020
@lguohan lguohan merged commit 0d1d6e1 into sonic-net:master Nov 20, 2020
@lguohan
Copy link
Contributor

lguohan commented Nov 20, 2020

i am glad to see kvm test prevent regression.

@jleveque jleveque deleted the fix_acl_loader branch November 20, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

Assignees

@jleveque jleveque

Labels
acl-loader/aclshow Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jleveque @lguohan