Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[201911] CRM show/config commands changes for multi-asic (#1127) #1236

Merged
merged 3 commits into from
Nov 26, 2020
Merged

[201911] CRM show/config commands changes for multi-asic (#1127) #1236

merged 3 commits into from
Nov 26, 2020

Conversation

judyjoseph
Copy link
Contributor

Including CRM changes in 201911 branch, #1127

@judyjoseph judyjoseph requested a review from abdosi November 13, 2020 21:52
@judyjoseph judyjoseph changed the title [multi-ASIC] CRM show/config commands changes for multi-asic (#1127) [201911] CRM show/config commands changes for multi-asic (#1127) Nov 13, 2020
@lgtm-com
Copy link

lgtm-com bot commented Nov 13, 2020

This pull request introduces 1 alert when merging 65ce7fd into d683bb4 - view on LGTM.com

new alerts:

  • 1 for Unused import

@judyjoseph
Copy link
Contributor Author

@abdosi , please wait for a while before merge.
There are pytest changes I have to still commit ( diff between master & 201911 )

@judyjoseph
Copy link
Contributor Author

@abdosi, Please take this PR into 201911 - I have verified that the unit tests were passing locally - thanks !

@jleveque
Copy link
Contributor

jleveque commented Nov 19, 2020 •
edited
Loading

@judyjoseph: FYI, yesterday I added support to Jenkins to properly test sonic-utilities PRs created against the 201911 branch.

@judyjoseph
Copy link
Contributor Author

@judyjoseph: FYI, yesterday I added support to Jenkins to properly test sonic-utilities PRs created against the 201911 branch.

Okay thanks Joe, will check the results then !

@judyjoseph
Copy link
Contributor Author

@jleveque , the unit tests are passing .. it seems to be failing here,

14:54:33  [htmlpublisher] Archiving at BUILD level /data/johnar/workspace/common/sonic-utilities-build-pr@2/sonic-utilities/htmlcov to /var/jenkins_home/jobs/common/jobs/sonic-utilities-build-pr/builds/3129/htmlreports/RCov_20Report
14:54:33  ERROR: Specified HTML directory '/data/johnar/workspace/common/sonic-utilities-build-pr@2/sonic-utilities/htmlcov' does not exist.
14:54:33  [Pipeline] publishCoverage (hide)
14:54:33  Publishing Coverage report....
14:54:33  No reports were found

Have you seen this error ? Could you check please ....

@jleveque
Copy link
Contributor

Retest this please

@judyjoseph
Copy link
Contributor Author

Retest this please

thanks @jleveque the tests pass now , @abdosi can you merge in for next build

@judyjoseph
Copy link
Contributor Author

retest this please

abdosi
abdosi approved these changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@abdosi abdosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think build failure is un-related. Merging this.

@abdosi abdosi merged commit 167d67a into sonic-net:201911 Nov 26, 2020
@judyjoseph judyjoseph deleted the 201911_crm branch November 26, 2020 00:56
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
@abdosi
[submodule update] sonic-utilities
be0f82e 
49cd91d (HEAD -> 201911, origin/201911) Feature table cli command update (sonic-net#1271)
167d67a [201911]  CRM show/config commands changes for multi-asic (sonic-net#1127) (sonic-net#1236)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdosi abdosi abdosi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@judyjoseph @jleveque @abdosi