-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building sonic-utilities as a Python wheel package instead of a Debian package #1122
Conversation
@@ -324,7 +324,7 @@ function reboot_pre_check() | |||
fi | |||
|
|||
# Make sure ASIC configuration has not changed between images | |||
ASIC_CONFIG_CHECK_SCRIPT="/usr/bin/asic_config_check" | |||
ASIC_CONFIG_CHECK_SCRIPT="/usr/local/bin/asic_config_check" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it doable not to change the path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, no. Wheels install to /usr/local/bin
, whereas .debs install to /usr/bin
. There's no way to change this behavior.
Build sonic-utilities as a Python wheel instead of a Debian package to support sonic-net/sonic-utilities#1122
Retest this please |
1 similar comment
Retest this please |
After reviewing the check build logs, it is apparent there is a chicken/egg problem, as the build copies artifacts from the last successful build of buildimage-vs-all. Therefore, the new sonic-utilities wheel package built here will not even get installed in the VS container before running the swss tests, making this test meaningless. I will merge this PR and update the submodule in sonic-net/sonic-buildimage#5409 and iterate on that PR if necessary. |
…cal/bin/ (#19) Update paths to reflect new sonic-utilities install location. As of PR sonic-net/sonic-utilities#1122, sonic-utilities is built and installed as a Python Wheel package. As such, the installation directory of the scripts/entrypoints has changed from `/usr/bin/` to `/usr/local/bin`. This patch updates all references to the old location to either reference the new location, or remove the absolute path entirely, where applicable.
- What I did
Support building sonic-utilities as a Python wheel package rather than a Debian package.
Notes:
- How I did it
data_files
section from setup.py- How to verify it
Ensure all CLI-related functionality continues to work as expected
NOTE: PR tests will fail until the build job is updated to build as a Python wheel. PR here: Azure/sonic-build-tools#160