Change fast-reboot script to use swss and radv service script #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
yxieca
previously approved these changes
Aug 11, 2020
|
retest this please |
yxieca
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Special handling is needed for services during fast, warm and cold reboot paths. This procedural handling is better suited in the respective service scripts to:
Call swss and radv service scripts to do special handling of reboot process behavior.
This PR should be merged only after service scripts changes are merged in following PRs:
RADV - sonic-net/sonic-buildimage#5108
SWSS - sonic-net/sonic-buildimage#5070
- How I did it
Created and modified service scripts to handle reboot procedure depending on the type. Fast-reboot script now simply calls these service scripts.
- How to verify it
Tested service scripts independently.
Tested Fast, warm and cold reboot procedures are tested.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)