Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[show]: Add 'ipv6' group along with 'bgp' and 'route' subcommands; Remove duplicate commands #102

Merged
merged 1 commit into from
Sep 20, 2017

Conversation

jleveque
Copy link
Contributor

  • Add 'ipv6' group along with 'bgp' and 'route' subcommands
  • Remove duplicate commands:
    • Remove 'arp' from under 'ip' group, now only under root group
    • Remove 'bgp' and 'route' commands from under root group (now different commands reside under 'ip' & 'ipv6')
    • Remove 'interfaces' from under 'ip' group, now only under root group

…licate commands ('bgp,' 'route') from under root group
@jleveque jleveque self-assigned this Sep 11, 2017
@jleveque jleveque changed the title Add 'ipv6' group along with 'bgp' and 'route' subcommands; Remove duplicate commands [show]; Add 'ipv6' group along with 'bgp' and 'route' subcommands; Remove duplicate commands Sep 12, 2017
@jleveque jleveque changed the title [show]; Add 'ipv6' group along with 'bgp' and 'route' subcommands; Remove duplicate commands [show]: Add 'ipv6' group along with 'bgp' and 'route' subcommands; Remove duplicate commands Sep 12, 2017
@nikos-github
Copy link
Contributor

nikos-github commented Sep 26, 2017

The bgp related changes are not necessarily correct and may need to be reverted/corrected. BGP shouldn't appear as an option under ipv6.

@stcheng
Copy link
Contributor

stcheng commented Sep 26, 2017

Hi @Nikos-Li could you create a separate issue? Since this pull request is already closed, the comment is hard to track.

@jleveque jleveque mentioned this pull request Sep 27, 2017
zhenggen-xu pushed a commit to zhenggen-xu/sonic-utilities that referenced this pull request Jun 6, 2018
* msft_github/master:
  Enhancement of 'show' commands and addition of 'debug', and 'undebug'… (sonic-net#113)
  CLI support for Layer 2 MAC/FDB show  (sonic-net#106)
  [show]: Add 'show interfaces alias' command to display port name/alias mapping (sonic-net#107)
  Add 'ipv6' group along with 'bgp' and 'route' subcommands; Remove duplicate commands ('bgp,' 'route') from under root group (sonic-net#102)
  [generate_dump]: Skip the sparse file /var/log/lastlog (sonic-net#104)
  Added syncd SAI dump to sysdump script (sonic-net#89)
  Adapt to new minigraph_parser schema (sonic-net#103)
  [core dump] remove number of parameter assumption from script coredump-compress
  [FastReboot]: Update FR to make it working with 1.0.3 (sonic-net#95)
vdahiya12 pushed a commit to vdahiya12/sonic-utilities that referenced this pull request Jul 23, 2021
…or physical entity mib (sonic-net#102)

* Update pmon daemons for SONiC Physical Entity MIB feature
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
…(#4193)

* [Mellanox]Integrate hw-mgmt 7.0000.3012

* [sonic-linux-kernel]Advance the submodule head

Advance the sonic-linux-kernel

[sFlow]: Patch to fix skb_over_panic in psample driver (sonic-net#120)
Added support in the kernel for fullcone 3-tuple unique nat. (sonic-net#100)
Adding support to compile ARM architecture (sonic-net#102)
[ixgbe] Support bcm54616s external phy in ixgbe (sonic-net#122)
Fix i2c ISMT DMA buffer alignment issue (sonic-net#123)
[mellanox]: Add SN4700 patches. (sonic-net#126)
mihirpat1 pushed a commit to mihirpat1/sonic-utilities that referenced this pull request Sep 15, 2023
- What I did
Following SFF-8472 to read diagnostic monitoring type register.
Use that register to check if diagnostic monitoring function implemented or not.

- How I did it
Check the register position from SFF-8472 document.
Read the register value from the EEPROM.
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Jan 27, 2025
…onic-net#102)

<!--
 Please make sure you've read and understood our contributing guidelines:
 https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

 failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` **

 If this is a bug fix, make sure your description includes "closes #xxxx",
 "fixes #xxxx" or "resolves #xxxx" so that GitHub automatically closes the related
 issue when the PR is merged.

 If you are adding/modifying/removing any command or utility script, please also
 make sure to add/modify/remove any unit tests from the tests
 directory as appropriate.

 If you are modifying or removing an existing 'show', 'config' or 'sonic-clear'
 subcommand, or you are adding a new subcommand, please make sure you also
 update the Command Line Reference Guide (doc/Command-Reference.md) to reflect
 your changes.

 Please provide the following information:
-->

#### What I did
Optimize techsupport collecting neighbor information having single call instead of multiple calls which increases techsupport time

#### How I did it
By combining all vtysh calls into one inside neighbor loop

#### How to verify it
Running techsupport with 256 neighbors. This reduces by more than 1.5 minutes

Before the fix
![image](https://github.com/user-attachments/assets/54114d39-03c2-4314-bc63-28f00d9a8b96)

After the fix
![image](https://github.com/user-attachments/assets/a0ba1b84-b46d-4c95-b622-44f3ef130b39)

#### Previous command output (if the output of a command-line utility has changed)

#### New command output (if the output of a command-line utility has changed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants