-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[show]: Add 'ipv6' group along with 'bgp' and 'route' subcommands; Remove duplicate commands #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jleveque
commented
Sep 11, 2017
- Add 'ipv6' group along with 'bgp' and 'route' subcommands
- Remove duplicate commands:
- Remove 'arp' from under 'ip' group, now only under root group
- Remove 'bgp' and 'route' commands from under root group (now different commands reside under 'ip' & 'ipv6')
- Remove 'interfaces' from under 'ip' group, now only under root group
…licate commands ('bgp,' 'route') from under root group
stcheng
approved these changes
Sep 20, 2017
The bgp related changes are not necessarily correct and may need to be reverted/corrected. BGP shouldn't appear as an option under ipv6. |
Hi @Nikos-Li could you create a separate issue? Since this pull request is already closed, the comment is hard to track. |
Closed
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-utilities
that referenced
this pull request
Jun 6, 2018
* msft_github/master: Enhancement of 'show' commands and addition of 'debug', and 'undebug'… (sonic-net#113) CLI support for Layer 2 MAC/FDB show (sonic-net#106) [show]: Add 'show interfaces alias' command to display port name/alias mapping (sonic-net#107) Add 'ipv6' group along with 'bgp' and 'route' subcommands; Remove duplicate commands ('bgp,' 'route') from under root group (sonic-net#102) [generate_dump]: Skip the sparse file /var/log/lastlog (sonic-net#104) Added syncd SAI dump to sysdump script (sonic-net#89) Adapt to new minigraph_parser schema (sonic-net#103) [core dump] remove number of parameter assumption from script coredump-compress [FastReboot]: Update FR to make it working with 1.0.3 (sonic-net#95)
vdahiya12
pushed a commit
to vdahiya12/sonic-utilities
that referenced
this pull request
Jul 23, 2021
…or physical entity mib (sonic-net#102) * Update pmon daemons for SONiC Physical Entity MIB feature
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
…(#4193) * [Mellanox]Integrate hw-mgmt 7.0000.3012 * [sonic-linux-kernel]Advance the submodule head Advance the sonic-linux-kernel [sFlow]: Patch to fix skb_over_panic in psample driver (sonic-net#120) Added support in the kernel for fullcone 3-tuple unique nat. (sonic-net#100) Adding support to compile ARM architecture (sonic-net#102) [ixgbe] Support bcm54616s external phy in ixgbe (sonic-net#122) Fix i2c ISMT DMA buffer alignment issue (sonic-net#123) [mellanox]: Add SN4700 patches. (sonic-net#126)
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
- What I did Following SFF-8472 to read diagnostic monitoring type register. Use that register to check if diagnostic monitoring function implemented or not. - How I did it Check the register position from SFF-8472 document. Read the register value from the EEPROM.
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Jan 27, 2025
…onic-net#102) <!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "closes #xxxx", "fixes #xxxx" or "resolves #xxxx" so that GitHub automatically closes the related issue when the PR is merged. If you are adding/modifying/removing any command or utility script, please also make sure to add/modify/remove any unit tests from the tests directory as appropriate. If you are modifying or removing an existing 'show', 'config' or 'sonic-clear' subcommand, or you are adding a new subcommand, please make sure you also update the Command Line Reference Guide (doc/Command-Reference.md) to reflect your changes. Please provide the following information: --> #### What I did Optimize techsupport collecting neighbor information having single call instead of multiple calls which increases techsupport time #### How I did it By combining all vtysh calls into one inside neighbor loop #### How to verify it Running techsupport with 256 neighbors. This reduces by more than 1.5 minutes Before the fix  After the fix  #### Previous command output (if the output of a command-line utility has changed) #### New command output (if the output of a command-line utility has changed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.