show interface counters for multi ASIC devices #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
|
This pull request introduces 2 alerts when merging 4deb0dc into c0c3cce - view on LGTM.com new alerts:
|
smaheshm
reviewed
Jul 31, 2020
scripts/portstat
Outdated
Comment on lines
24
to
31
| from utilities_common.constants import DISPLAY_EXTERNAL | ||
| from utilities_common.constants import DISPLAY_ALL | ||
| from utilities_common.constants import PORT_OBJ | ||
| from utilities_common.netstat import ns_diff, ns_brate, ns_prate, ns_util, table_as_json | ||
| from utilities_common.intf_filter import parse_interface_in_filter | ||
| from utilities_common.multi_asic import MultiAsic | ||
| from utilities_common.multi_asic import run_on_all_asics | ||
|
|
There was a problem hiding this comment.
some of them can be grouped togetherr
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
|
This pull request introduces 1 alert when merging 7e69c2d into 8768580 - view on LGTM.com new alerts:
|
|
missing unit tests? |
lguohan
reviewed
Aug 21, 2020
show/main.py
Outdated
| @@ -20,6 +20,7 @@ | |||
| import utilities_common.cli as clicommon | |||
|
|
|||
| import mlnx | |||
| from utilities_common.multi_asic import multi_asic_click_options | |||
There was a problem hiding this comment.
move up to line 21 so they are grouped.
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
|
This pull request introduces 1 alert when merging 0e18118 into 2c0ff92 - view on LGTM.com new alerts:
|
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
|
This pull request introduces 2 alerts when merging 17cdd63 into 62e44d9 - view on LGTM.com new alerts:
|
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
|
This pull request fixes 1 alert when merging c68d38e into 8d6d871 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 3e37a85 into 96cb359 - view on LGTM.com fixed alerts:
|
jleveque
approved these changes
Sep 8, 2020
arlakshm
added a commit
to arlakshm/sonic-utilities
that referenced
this pull request
Sep 9, 2020
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
arlakshm
added a commit
that referenced
this pull request
Sep 10, 2020
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com> Add support for multi ASIC CLI options for show interface portchannels. This PR is port of #1013 to 201911 - Change the portstat script to get the interface counters from all the Namespaces - Add support for -n and -s options to portstat scripts - Add unit test for single and multi asic
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the multi ASIC specific options for the command show interface portchannel
Depends on the following PRs
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan arlakshm@microsoft.com
- What I did
Add support for multi ASIC CLI options for show interface portchannels
2 new options have added
[-n, --namespace] to allow user to display the information for given namespaces
If this option is not present the information from all the namespaces will be displayed
[-d, --display] to allow user to display information related both internal and external interfaces
If this option is not present only external interfaces/neighbors will be display
One single ASIC platform, this options are not valid, so the behavior remains unchanged
- How I did it
This new options are ignored for single ASIC platforms
- How to verify it
Help menu
show interface counters for all ports in multi ASIC device
**show interface counters for specific ASIC **
Counters for internal and external interfaces
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)