Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GCU] Check if BGP_INTERNAL_NEIGHBOR, BGP_MONITORS, BGP_PEER_RANGE, BGP_VOQ_CHASSIS_NEIGHBOR fields are create-only #2029

Closed
ghooo opened this issue Jan 21, 2022 · 4 comments · Fixed by #2092
Closed

[GCU] Check if BGP_INTERNAL_NEIGHBOR, BGP_MONITORS, BGP_PEER_RANGE, BGP_VOQ_CHASSIS_NEIGHBOR fields are create-only #2029

ghooo opened this issue Jan 21, 2022 · 4 comments · Fixed by #2092
Assignees
@ghooo
Labels
generic-config-updater

Comments

@ghooo
Copy link
Contributor

ghooo commented Jan 21, 2022

Description

Create-Only fields are only created with their parent, but cannot be modified later.

Steps to reproduce the issue

Describe the results you received

Describe the results you expected

Additional information you deem important (e.g. issue happens only occasionally)

Output of show version

(paste your output here)
@ghooo ghooo self-assigned this Jan 21, 2022
@ghooo ghooo mentioned this issue Jan 21, 2022
Merged
@ghooo ghooo mentioned this issue Jan 28, 2022
Merged
5 tasks
@wen587 wen587 mentioned this issue Feb 11, 2022
Closed
@qiluo-msft qiluo-msft added the p0 label Mar 4, 2022
@ghooo ghooo mentioned this issue Mar 4, 2022
Merged
@ghooo
Copy link
Contributor Author

ghooo commented Mar 4, 2022

@qiluo-msft I didn't find a YANG table for BGP_INTERNAL_NEIGHBOR nor BGP_VOQ_CHASSIS_NEIGHBOR. I need to know the fields under these tables so I can double check if they are create-only or not.

@qiluo-msft qiluo-msft removed the p0 label Mar 4, 2022
@qiluo-msft
Copy link
Contributor

@ganglyu These tables are missing yang models and also minigraph parsing/validation unit test.

This was referenced Mar 7, 2022
Closed
Closed
@ganglyu
Copy link
Contributor

ganglyu commented Mar 7, 2022

sonic-net/sonic-buildimage#10157
sonic-net/sonic-buildimage#10158
I have created above issues to trace this requirement, and I will discuss with BGP owner and Multi-asic team to add these Yang models.

@ganglyu
Copy link
Contributor

ganglyu commented Mar 7, 2022

@qiluo-msft I didn't find a YANG table for BGP_INTERNAL_NEIGHBOR nor BGP_VOQ_CHASSIS_NEIGHBOR. I need to know the fields under these tables so I can double check if they are create-only or not.

https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-config-engine/minigraph.py#L727
Please refer to above link, it seems that BGP_INTERNAL_NEIGHBOR and BGP_VOQ_CHASSIS_NEIGHBOR are similar, and the fields under these tables are: name, local_addr, rrclient, holdtime, keepalive, nhopself, admin_status and asn.

qiluo-msft pushed a commit that referenced this issue Mar 9, 2022
@ghooo
[GCU] Marking fields under BGP_PEER_RANGE, BGP_MONITORS as create-only (
2c56e92 
#2092)

#### What I did
Fixes #2029 #2062

Changes to fields under BGP_PEER_RANGE, BGP_MONITORS using GCU are not reflected unless each key is deleted and added back. This means the fields are create-only.

#### How I did it
Marked the fields under BGP_PEER_RANGE, BGP_MONITORS as create-only

#### How to verify it
unit-test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghooo ghooo

Labels
generic-config-updater
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[GCU] Marking fields under BGP_PEER_RANGE, BGP_MONITORS as create-only ghooo/sonic-utilities
3 participants
@ghooo @qiluo-msft @ganglyu