Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buffer pool watermark support #853

Merged
merged 16 commits into from
Jun 14, 2019
Merged

Conversation

wendani
Copy link
Contributor

@wendani wendani commented Apr 23, 2019

  1. Write fields to FLEX_COUNTER_GROUP_TABLE at the construction of a BufferOrch object:

    "POLL_INTERVAL"
    "BUFFER_POLL_PLUGIN_LIST"
    "STATS_MODE"

  2. Update buffer pool name to oid mapping in COUNTERS_DB upon the set and del of its oid

  3. Push buffer pool watermark COUNTER_ID_LIST to FLEX_COUNTER_TABLE

  4. Implement user clear logic to buffer pool watermark

  5. Add periodic clear to buffer pool watermark

  6. Add lua script for watermark_bufferpool

What I did

Why I did it

How I verified it
On brcm dut
Details if related
Depend on:
sonic-net/sonic-swss-common#272 Add schema for buffer pool watermark
sonic-net/sonic-buildimage#2818 Feed device info to orchagent process

Alongside:
sonic-net/sonic-sairedis#451 Add buffer pool stat to flex counter architecture

Downstream changes:
sonic-net/sonic-utilities#521 Add buffer pool watermark support in watermarkstat and counterpoll

syncd rpc support:
opencomputeproject/SAI#949

a BufferOrch object:

"POLL_INTERVAL"
"BUFFER_POLL_PLUGIN_LIST"
"STATS_MODE"

Signed-off-by: Wenda Ni <wenni@microsoft.com>
…d del of its oid

Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Copy link
Contributor Author

wendani commented Apr 23, 2019

@mykolaf for review

orchagent/bufferorch.h Outdated Show resolved Hide resolved
@wendani wendani requested a review from qiluo-msft May 31, 2019 03:53
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@sonic-net sonic-net deleted a comment from lguohan Jun 12, 2019
@wendani wendani requested a review from qiluo-msft June 12, 2019 23:06
@wendani
Copy link
Contributor Author

wendani commented Jun 14, 2019

retest this please

@wendani wendani merged commit 4577b40 into sonic-net:master Jun 14, 2019
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants