Create egress ACL table group during the PFCWD stats list installment #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wenda <wenni@microsoft.com>
wendani
changed the title
lguohan
reviewed
Feb 9, 2019
orchagent/pfcwdorch.cpp
Outdated
|
|
||
| // Create egress table group for each port of pfcwd's interest | ||
| sai_object_id_t group_member_oid; | ||
| gPortsOrch->bindAclTable(port.m_port_id, SAI_NULL_OBJECT_ID, group_member_oid, ACL_STAGE_EGRESS); |
There was a problem hiding this comment.
this is not correct. you want to reuse bindAclTable function, but you return false if table_oid == NULL.
You want to create an empty table group, the return should be success, not false.
I suggest you to define a new function createAclTableGroup(), and call gPortsOrch->createAclTableGroup(port.m_port_id, ACL_STAGE_EGRESS)
Then, you rewrite bindAclTable to use createAclTableGroup.
group to a port, which can be physical, vlan, or lag Signed-off-by: Wenda <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
lguohan
approved these changes
Feb 10, 2019
Signed-off-by: Wenda Ni <wenni@microsoft.com>
|
Made to 201811 branch on 2019/2/21 |
yxieca
pushed a commit
that referenced
this pull request
Feb 21, 2019
…#787) * Create egress table group during the PFCWD stats list installment Signed-off-by: Wenda <wenni@microsoft.com> * Introduce function bindAclTableGroup() to create and bind ACL table group to a port, which can be physical, vlan, or lag Signed-off-by: Wenda <wenni@microsoft.com> * Rename function to createBindAclTableGroup() Signed-off-by: Wenda Ni <wenni@microsoft.com> * Check the validity of ACL table oid Signed-off-by: Wenda Ni <wenni@microsoft.com>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Will be needed for asic compare.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenda wenni@microsoft.com
What I did
On the PFCWD stats list installment, create egress ACL table group for each port and bind to it.
Why I did it
In pfc watchdog warm-reboot, we find that brcm sai not supporting ACL table group port unbind yet. If pfc storm ever occurred on a port, egress ACL table group will be created and bound to the port, and persist the association with the port even after the storm is restored. In the situation that there is restored but not ongoing pfc storm before warm-reboot, egress table group will not be created in view after warm-reboot. Syncd comparison logic will see the difference, and remove the egress ACL table group object from the port, the underlying unbind operation of which is not supported in brcm sai yet.
We use the workaround solution that we created egress table group proactively for all ports under PFCWD's surveillance so that syncd will not see the difference post warm-reboot even if pfc storm ever occurs on a port.
How I verified it
Details if related