Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[virtual test] fix a unstable egress ACL test #776

Merged
merged 8 commits into from
Feb 1, 2019
Merged

[virtual test] fix a unstable egress ACL test #776

merged 8 commits into from
Feb 1, 2019

Conversation

keboliu
Copy link
Collaborator

@keboliu keboliu commented Jan 31, 2019

What I did
fix egress ACL table creation test.

Why I did it
the test could failed sometimes.
How I verified it
run virtual test
Details if related

@keboliu
Copy link
Collaborator Author

keboliu commented Jan 31, 2019

retest this please

1 similar comment
@stcheng
Copy link
Contributor

stcheng commented Jan 31, 2019

retest this please

@lguohan
Copy link
Contributor

lguohan commented Feb 1, 2019

this is good fix. the two failures are not caused by this PR.

TestSpeedSet.test_SpeedAndBufferSet
test_PortAutoNeg_warm

@lguohan lguohan merged commit 9f20eda into sonic-net:master Feb 1, 2019
@jipanyang
Copy link
Contributor

this is good fix. the two failures are not caused by this PR.

TestSpeedSet.test_SpeedAndBufferSet
test_PortAutoNeg_warm
I was scratching my head about these two failing case on my local environment. Same swss code, passed before but failing now. Guess some sonic-buildimage vs change triggered the failure.

@lguohan
Copy link
Contributor

lguohan commented Feb 1, 2019

i'll send pr to fix them shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants