[aclorch]: only bind to port for ACL_TABLE_PFCWD type #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sihui Han <sihan@microsoft.com>
prsunny
reviewed
Aug 3, 2018
orchagent/aclorch.cpp
Outdated
| @@ -1022,7 +1022,7 @@ bool AclTable::create() | |||
|
|
|||
| sai_attribute_t attr; | |||
| vector<sai_attribute_t> table_attrs; | |||
| vector<int32_t> bpoint_list = { SAI_ACL_BIND_POINT_TYPE_PORT, SAI_ACL_BIND_POINT_TYPE_LAG }; | |||
| vector<int32_t> bpoint_list = type == ACL_TABLE_PFCWD ? { SAI_ACL_BIND_POINT_TYPE_PORT} : { SAI_ACL_BIND_POINT_TYPE_PORT, SAI_ACL_BIND_POINT_TYPE_LAG }; | |||
There was a problem hiding this comment.
If LAG binding is not supported on egress, will it be better to check the stage and select the binding point?
There was a problem hiding this comment.
offline discussed with guohan, currently only brcm pfcwd use egress acl and only brcm might have egress lag bind issue. Other platforms might still be available to use egress LAG binding. So it's better to restrict port binding for PFCWD which is also by design for this use case.
Signed-off-by: Sihui Han <sihan@microsoft.com>
sihuihan88
force-pushed
the
dev/sihan/bind
branch
2 times, most recently
from
b3ad47f to
401d619
Compare
prsunny
approved these changes
Aug 3, 2018
|
retest this please |
qiluo-msft
added a commit
that referenced
this pull request
Aug 4, 2018
This reverts commit 6556b26.
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…mand, etc., (sonic-net#561) * Modified CLI doc for 201904 release, changed the config interface commands to reflect interfacename sequence change, explained the diff w.r.t FRR/Quagga * Addressed review comments; corrected few syntax issues; explicitly showed the differences in the commands between 201904 version and older versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sihui Han sihan@microsoft.com
What I did
Only bind to port for ACL_TABLE_PFCWD type
Why I did it
PFCWD only requires to bind to port regardless if port is a LAG member. And LAG binding is not supported for egress acl table which will be used for PFCWD.
How I verified it
Details if related