[orchagent]: Remove the global variable gPortsOrch in orch.cpp file #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is the first step of refactoring Orch class. The global variable gPortsOrch is removed from that orch.cpp file and this class no longer requires such external variable. The current solution is to move the global variable into each different places that need this variable. Later, a better design could be introduced to further remove all the global variables from the whole project. Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
|
@JipanYanga could you check this pull request? thanks. |
|
@stcheng As the first step of eliminating global variables from Orch class, the change looks good to me. |
lguohan
approved these changes
Nov 2, 2017
|
If global variable gPortsOrch is removed from orch.cpp, why |
|
@andriymoroz-mlnx ah thanks, i'll remove it. |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
This reverts commit 7a51a85.
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
* Add VS support for setting stats via redis DB channel * Remove SET description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is the first step of refactoring Orch class.
The global variable gPortsOrch is removed from that orch.cpp file
and this class no longer requires such external variable.
The current solution is to move the global variable into each different
places that need this variable. Later, a better design could be
introduced to further remove all the global variables from the whole
project.
Signed-off-by: Shu0T1an ChenG shuche@microsoft.com
What I did
Remove the gPortsOrch from the orch.cpp file.
Why I did it
Free the orch.cpp file.
How I verified it
Compile and run the code.