SRv6: bypass test failures introduced by sonic-buildimage changes #3483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
force-pushed
the
bradh352/test-issues
branch
from
378dd2e to
e0f537b
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
force-pushed
the
bradh352/test-issues
branch
from
e0f537b to
c62e363
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
changed the title
bradh352
force-pushed
the
bradh352/test-issues
branch
from
c62e363 to
428d817
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
force-pushed
the
bradh352/test-issues
branch
from
428d817 to
3b1bb52
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
force-pushed
the
bradh352/test-issues
branch
from
d637702 to
2455390
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
force-pushed
the
bradh352/test-issues
branch
from
2455390 to
38b3fdc
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
As of sonic-net/sonic-buildimage#21467 some tests are failing due to a validation that `block-len+node-len = locator-len`. However in some of the test cases this wasn't actually true, meaning the tests were invalid as designed. Update the test cases to be valid by this logic. Should also universally wait for interface deletion at tear down to make sure it doesn't cause failures in the next test. Signed-off-by: Brad House (@bradh352)
bradh352
force-pushed
the
bradh352/test-issues
branch
from
10d47c6 to
db1d70f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
changed the title
|
@cscarpitta can you look into these SRv6 swss test regressions? |
These need to be looked into by SRv6 maintainers.
bradh352
force-pushed
the
bradh352/test-issues
branch
from
db1d70f to
db81605
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@bradh352 The issue has been fixed in this PR sonic-net/sonic-buildimage#21534 |
Thanks, does the |
|
closing in favor of PR #3486 and sonic-net/sonic-buildimage#21534 |
Many thanks @bradh352 for reporting the issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This makes a change to fix a reported validation failure that requires
block-len+node-len = locator-len(which correcting it doesn't actually resolve all the test failures), then skips the failing tests.Whoever is in charge of SRv6 needs to investigate.
Why I did it
It appears sonic-net/sonic-buildimage#21467 introduced the regression causing all sonic-swss PRs to fail their test cases.
How I verified it
Build/test results from this PR.
Details if related
Signed-off-by: Brad House (@bradh352)