Remove wrong table attr #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stcheng
reviewed
Aug 7, 2017
| @@ -1409,10 +1409,6 @@ sai_status_t AclOrch::createBindAclTable(AclTable &aclTable, sai_object_id_t &ta | |||
| attr.value.s32 = SAI_ACL_STAGE_INGRESS; | |||
| table_attrs.push_back(attr); | |||
|
|
|||
| attr.id = SAI_ACL_TABLE_GROUP_MEMBER_ATTR_PRIORITY; | |||
There was a problem hiding this comment.
why remove this? this is not the table size.
There was a problem hiding this comment.
This is an attribute for table group member, not for table. It will act as table size if we use this enum.
stcheng
approved these changes
Aug 7, 2017
praveen-li
pushed a commit
to praveen-li/sonic-swss
that referenced
this pull request
Aug 24, 2020
* msft_github/master: [swssconfig]: Update Mellanox buffer profile template to work with an incomplete minigraph (sonic-net#332) [portsyncd]: Remove deprecated sample file port_config.ini (sonic-net#330) [portsyncd]: Remove unused LAG related tables (sonic-net#329) [tunnelorch]: Minor comment update [aclorch]: Fix crashing when removing ACL table that has associated ACL rules (sonic-net#322) [pfcwdorch]: Initial support (sonic-net#317) [swssconfig]: Update buffer profile template to work with CONF_DB (sonic-net#319) [aclorch]: Refactor doAclTableTask and doAclRuleTask (sonic-net#318) [swssconfig]: Add Mellanox PG buffer profiles based on port configuration (sonic-net#301) [switchorch]: Add SwitchOrch to deal with switch attributes changes (sonic-net#314) [github]: Update pull request template comments [github]: Add pull request template (sonic-net#313) Optimize orch performance by pops() (sonic-net#312) Refactor TableConsumable (sonic-net#291) [buffer]: Remove failed tasks from the m_toSync queue (sonic-net#308) [qos]: Remove failed tasks from the m_toSync queue (sonic-net#306) [aclorch]: Add match TC support for ACL rule (sonic-net#302) [orchagent]: Set log recording directory before enable recording (sonic-net#300) [orchagent]: Remove duplicate SwSS recording file set code (sonic-net#298) Fix port speed validation (sonic-net#288) [fdborch]: Fix FdbOrch code to work upon SAI v1.0 (sonic-net#284) [config]: Add BGPv6 COPP in 00-copp.config.json (sonic-net#281) [aclorch]: Fix match DSCP attribute value mask length to 0x3F [mirrororch]: Set the VLAN header only when the packet is mirrored to a VLAN (sonic-net#282) [swssconfig]: Log errors instead of throwing exception when file open fails (sonic-net#277) [aclorch]: Remove wrong table attribute (sonic-net#280) [aclorch]: Fix remove_acl_counter function to remove the counter (sonic-net#274) [copporch]: Add SAI_HOSTIF_TRAP_ATTR_TRAP_PRIORITY support and refactor code (sonic-net#270) [mirrororch]: Add SAI_MIRROR_SESSION_ATTR_VLAN_HEADER_VALID (sonic-net#269) [bufferorch]: Add SAI_BUFFER_PROFILE_THRESHOLD_MODE_* (sonic-net#271) [aclorch]: Minor logs fix [orchagent]: Update recording file name to swss.rec [Make]: Fix type conversions and add more warnings (sonic-net#267) [aclorch]: Fix ACL table group attribute type issue (sonic-net#268) [portsorch]: Update default bridge port removal logic (sonic-net#263) [routeorch]: Need to set drop route next hop ID to NULL (sonic-net#261) [portsorch]: Remove SAI_PORT_ATTR_BIND_MODE (sonic-net#262) [portsorch]: Create a bridge port with admin status set to UP (sonic-net#259) Revert "[portsorch]: Set port bind mode after adding VLAN member" (sonic-net#258) [orchagent]: Temporarily fix pre-allocated bridge_port_list size (sonic-net#256) [saihelper]: Create initSaiRedis function and put related code inside it (sonic-net#254) [portsorch]: Set port bind mode after adding VLAN member (sonic-net#251) [orchagent]: Create the switch with source MAC address (sonic-net#253) [copporch]: Add UDLD entry in COPP (sonic-net#252) [orchagent]: Support LAG/VLAN with SAI 1.0 (sonic-net#250) use vlan oid instead of vlan id (sonic-net#247) Fix getBridgePort: handle non existing bridge_port_id Integration for SAI v1.0.1 Remove vlan member before removing bridge port Fix SAI functional calls Fix: store bridge ports at initialization Refactor vector<attr> Resolve review comments Implement bridge port in portsorch Fix initSystemAclTable: bind system ACL to each port Refactor: port owns acl table group Resolve code review comments Resolve code review comments Adpat SAIv1.0 headers and fix compilation errors
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
lukasstockner
pushed a commit
to genesiscloud/sonic-swss
that referenced
this pull request
Apr 2, 2023
…hen mux toggle is inprogress (sonic-net#280) In this PR, there is a support for adding a mux_toggle_status variable inside the base class for mux_cable. Using this variable the Derived classes for mux_cable can check this and return in case of a mux_toggle_status is in progress. From the higher layer this allows ycabled to synchronize the calls and not let mux_cable toggle to go in conjunction with some of the Telemetry calls. Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com Description Motivation and Context To get the toggle time to a minimum/ not allow i2c to transactions on the cable to collide with each other How Has This Been Tested? Ran the changes on 7050cx3 arista testbed Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.