Comment add for rif counters cleanup (fix for #2270) #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumanbrcm
changed the title
|
Added @Junchao-Mellanox and @dgsudharsan |
Junchao-Mellanox
approved these changes
May 13, 2022
prsunny
approved these changes
May 13, 2022
preetham-singh
pushed a commit
to preetham-singh/sonic-swss
that referenced
this pull request
Aug 6, 2022
*Added a comment for TODO . This comment is for reminding existence of a race condition and moving the cleanup code to syncd .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix for https://github.com/Azure/sonic-swss/issues/2270
Added a comment for TODO . This comment is for reminding existence of a race condition and moving the cleanup code to syncd .
Why I did it
This is done in follow-up to fix in #2199
The comment is added as TODO - in future the cleanup for rif counters should move to syncd.
How I verified it
No explicit verification is needed for this.