[macsecorch]: Fix deleting MACsec bug #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ze Gan <ganze718@gmail.com>
Pterosaur
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@Pterosaur , is the vstest failure related to this pr or not related, if it is not, can you ask @prsunny to check? |
Sure, I have connected Prince. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
judyjoseph
approved these changes
Feb 18, 2022
dprital
pushed a commit
to dprital/sonic-swss
that referenced
this pull request
May 8, 2022
* Fix delete MACsec bug Signed-off-by: Ze Gan <ganze718@gmail.com> * Fix Signed-off-by: Ze Gan <ganze718@gmail.com>
preetham-singh
pushed a commit
to preetham-singh/sonic-swss
that referenced
this pull request
Aug 6, 2022
* Fix delete MACsec bug Signed-off-by: Ze Gan <ganze718@gmail.com> * Fix Signed-off-by: Ze Gan <ganze718@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ze Gan ganze718@gmail.com
What I did
Fix a segment fault in MACsec orchagent to record the next iterator before deleting the corresponding MACsec object.
Why I did it
The segment fault will happen if to delete the MACsec Port or MACsec SC that have MACsec SC(s) or MACsec SA(s), Because the original implementation used the for loop to iterate all MACsec sub objects, but the MACsec sub object will be delete on each iteration so that the removed iterator cannot go to the next one.
How I verified it
Use
appl_db_del(appl_db, "MACSEC_PORT_TABLE", ifname)to delete a MACsec port that has MACsec SC, The segment fault shouldn't happen.Details if related