Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crm] Use sai_object_type_get_availability() API to get counters #2098

Merged
merged 2 commits into from
Mar 1, 2022

Conversation

volodymyrsamotiy
Copy link
Collaborator

@volodymyrsamotiy volodymyrsamotiy commented Jan 4, 2022

Signed-off-by: Volodymyr Samotiy volodymyrs@nvidia.com

What I did
Aligned supported CRM resources with the newest way to get counters using sai_object_type_get_availability() API.

Why I did it
To use newest way to get CRM counters

How I verified it
Run CRM test from sonic-mgmt

Details if related
N/A

@volodymyrsamotiy volodymyrsamotiy marked this pull request as ready for review January 4, 2022 08:25
@liat-grozovik
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

@prsunny while you are reviewing this change, please consider adding it to 202111 and add the right label.

@liat-grozovik
Copy link
Collaborator

/azp run Azure.sonic-swss

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

/azp run Azure.sonic-swss

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
@volodymyrsamotiy volodymyrsamotiy changed the title [crm] Align with the newest way to get counters using sai_object_type… [crm] Use sai_object_type_get_availability() API to get counters Feb 9, 2022
@volodymyrsamotiy
Copy link
Collaborator Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

/azp run Azure.sonic-swss

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@volodymyrsamotiy
Copy link
Collaborator Author

/azp run Azure.sonic-swss

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 2098 in repo Azure/sonic-swss

@volodymyrsamotiy
Copy link
Collaborator Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@volodymyrsamotiy
Copy link
Collaborator Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

@prsunny kindly reminder to review and signoff
please note that the LTGM issue seen on other PRs also seen here. I suggest to take further look as it seems like SAI/sairedis issue.

@prsunny prsunny merged commit 828cccf into sonic-net:master Mar 1, 2022
judyjoseph pushed a commit that referenced this pull request Mar 7, 2022
*Aligned supported CRM resources with the newest way to get counters using sai_object_type_get_availability() API.
Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
preetham-singh pushed a commit to preetham-singh/sonic-swss that referenced this pull request Aug 6, 2022
…ic-net#2098)

*Aligned supported CRM resources with the newest way to get counters using sai_object_type_get_availability() API.
Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants