OA changes to support Ordered ECMP and DVS test for same. #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
|
This pull request fixes 1 alert when merging 3ec64d0 into 691c37b - view on LGTM.com fixed alerts:
|
shi-su
reviewed
Jan 6, 2022
orchagent/switchorch.h
Outdated
| @@ -10,6 +10,7 @@ | |||
|
|
|||
| #define SWITCH_CAPABILITY_TABLE_PORT_TPID_CAPABLE "PORT_TPID_CAPABLE" | |||
| #define SWITCH_CAPABILITY_TABLE_LAG_TPID_CAPABLE "LAG_TPID_CAPABLE" | |||
| #define SWITCH_CAPABILITY_ORDERED_ECMP_CAPABLE "ORDERED_ECMP_CAPABLE" | |||
There was a problem hiding this comment.
Should this be named SWITCH_CAPABILITY_TABLE_ORDERED_ECMP_CAPABLE for better consistency?
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
shi-su
previously approved these changes
Jan 6, 2022
|
This pull request fixes 1 alert when merging 9322837 into 691c37b - view on LGTM.com fixed alerts:
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This pull request fixes 1 alert when merging e5a958c into 6dae6b8 - view on LGTM.com fixed alerts:
|
shi-su
previously approved these changes
Jan 11, 2022
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
shi-su
approved these changes
Jan 12, 2022
|
This pull request fixes 1 alert when merging 8931ec4 into 8fd6e48 - view on LGTM.com fixed alerts:
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dprital
pushed a commit
to dprital/sonic-swss
that referenced
this pull request
May 8, 2022
…2092) What I did:- Orchagent changes to support Ordered ECMP as per design Order ECMP HLD. SONiC#896 While testing Order ECMP for Overlay ECMP use case found that for single nexthop based tunnel we create route without checking BFD state for endpoint. This results in not needed transaction of add_route followed by del_route. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
preetham-singh
pushed a commit
to preetham-singh/sonic-swss
that referenced
this pull request
Aug 6, 2022
…2092) What I did:- Orchagent changes to support Ordered ECMP as per design Order ECMP HLD. SONiC#896 While testing Order ECMP for Overlay ECMP use case found that for single nexthop based tunnel we create route without checking BFD state for endpoint. This results in not needed transaction of add_route followed by del_route. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:-
add_routefollowed bydel_route.How I verify:-
trueandfalse.