Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reclaiming buffer][202106] Support reclaiming buffer in traditional model #2039

Closed
wants to merge 2 commits into from
Closed

[Reclaiming buffer][202106] Support reclaiming buffer in traditional model #2039

wants to merge 2 commits into from

Conversation

stephenxs
Copy link
Collaborator

@stephenxs stephenxs commented Nov 19, 2021 •
edited
Loading

What I did
It's to port #2011 to 202106
To reclaim reserved buffer.
As the way to do it differs among vendors, buffermgrd will:

  • Handle port admin down on Mellanox platform.
    • Not apply lossless buffer PG to an admin-down port
    • Remove lossless buffer PG (3-4) from a port when it is shut down.
  • Readd lossless buffer PG (3-4) to a port when a port is started up.

Signed-off-by: Stephen Sun stephens@nvidia.com

Why I did it
To support reclaiming reserved buffer when a port is shut down on Mellanox platform in traditional buffer model.

How I verified it

Regression test and vs test.

Details if related

@stephenxs
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs stephenxs marked this pull request as ready for review November 24, 2021 14:05
@stephenxs stephenxs requested a review from prsunny as a code owner November 24, 2021 14:05
@stephenxs stephenxs requested a review from neethajohn November 24, 2021 14:05
@stephenxs stephenxs mentioned this pull request Nov 25, 2021
Merged
@stephenxs
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs
Copy link
Collaborator Author

It can be cherry-picked to 202012 branch (commit e37302d) cleanly, so tag added.

@stephenxs
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@neethajohn
Copy link
Contributor

@prsunny , do we do such kind of cherry-picks? from non master branch?

@prsunny
Copy link
Collaborator

prsunny commented Dec 3, 2021 •
edited
Loading

agree with Neetha. typically we don't follow this model. if it cannot be cherry-picked from master, please raise separate PRs to release branches.

@stephenxs
Copy link
Collaborator Author

agree with Neetha. typically we don't follow this model. if it cannot be cherry-picked from master, please raise separate PRs to release branches.

Thanks for clarifying it. Will open another PR for 202012. Thanks.

@stephenxs
Copy link
Collaborator Author

agree with Neetha. typically we don't follow this model. if it cannot be cherry-picked from master, please raise separate PRs to release branches.

Thanks for clarifying it. Will open another PR for 202012. Thanks.

PR #2063 created for 202012.

@qiluo-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

/azp run Azure.sonic-swss

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs
Copy link
Collaborator Author

Currently, the PR depends on #2118 for the vstest failure.

@liat-grozovik
Copy link
Collaborator

/azp run Azure.sonic-swss

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs stephenxs closed this Mar 28, 2022
@stephenxs stephenxs deleted the reclaim-buffer-traditional-202106 branch May 26, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neethajohn neethajohn neethajohn approved these changes

@prsunny prsunny Awaiting requested review from prsunny prsunny is a code owner

Assignees
No one assigned
Labels
Request for 202106 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stephenxs @mssonicbld @neethajohn @prsunny @qiluo-msft @liat-grozovik