Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SWSS] VOQ Nexthop for remote VOQ LC should be created on inband OIF. #1823

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

minionatwork
Copy link
Contributor

What I did

VOQ nexthop for remote neighbors should be created on local inband port only for the kernel purpose. SAI should use actual RIF of the remote system port interface. #1686 seems to be break this condition and this change address it.

Why I did it
VOQ nexthop for remote neighbors should be created on local inband port only for the kernel purpose. SAI should use actual RIF of the remote system port interface. #1686 seems to be break this condition and this change address it.

How I verified it
Test on VOQ chassis.

Details if related

@abdosi
Copy link
Contributor

abdosi commented Jul 21, 2021

would this issue could have covered by unit test ? If so can we add now

@minionatwork
Copy link
Contributor Author

@abdosi can you approve this one and merge?. @vganesan-nokia is adding UT in separate PR.

@abdosi
Copy link
Contributor

abdosi commented Aug 5, 2021

can we add test case as part of this repo ? this can be common repo and we can collaborate.

@vganesan-nokia
Copy link
Contributor

can we add test case as part of this repo ? this can be common repo and we can collaborate.

@abdosi, there will not be any new test case for this. The system neighbor test case in sonic-swss/tests/test_virtual_chassis.py will be enhaced to check for presence of the neighbor in the kernel on Ethernet-IB (inband) interface. This will be done in a separate PR after PR #1811 is merged.

@abdosi abdosi merged commit df96059 into sonic-net:master Aug 5, 2021
@vganesan-nokia
Copy link
Contributor

@abdosi, I just checked the sonic-swss/test_virtual_chassis.py for enhancing system neighbor test. The voq system neigh test already checks for presence of the neighbor in kernel on the inband interface. But this test is skipped by PR #1807. Since the PR #1686 was merged just after the PR #1807 was merged, virtual chassis tests did not catch the problem introduced by PR #1686.

The problem that lead to skipping the virtual chassis tests has been fixed by PRs sonic-net/sonic-buildimage#8008 and PR #1811. The PR #1811 also enables the skipped tests. So just merging PR sonic-net/sonic-buildimage#8008 and PR #1811 will be enough. We do not need any enhancements in virtual chassis tests by another PR.

Tagging Anshu and Suresh, for their info: @anshuv-mfst , @minionatwork

judyjoseph pushed a commit that referenced this pull request Aug 18, 2021
VOQ nexthop for remote neighbors should be created on local inband port only for the kernel purpose. SAI should use actual RIF of the remote system port interface. #1686 seems to be break this condition and this change address it.
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-swss that referenced this pull request Oct 5, 2021
…c-net#1823)

VOQ nexthop for remote neighbors should be created on local inband port only for the kernel purpose. SAI should use actual RIF of the remote system port interface. sonic-net#1686 seems to be break this condition and this change address it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants