[bufferorch][201911] Handle DEL_COMMAND for BUFFER_PG and BUFFER_QUEUE table #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM failed due to a compiling error which didn't happen on my local server. Will retry. |
|
I think this is a known issue with 201911. @abdosi ? |
|
I believe these flows should be verified by unit test/VS. can you please add? |
Ok. Will check it. |
VS test added. |
stephenxs
changed the title
|
@neethajohn kindly reminder to review this PR |
neethajohn
approved these changes
Jul 9, 2021
|
Commenter does not have sufficient privileges for PR 1787 in repo Azure/sonic-swss |
|
/azpw run |
1 similar comment
|
/azpw run |
|
@abdosi kindly reminder. This is a bug fix that need to go into 201911 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
stephenxs
force-pushed
the
201911-handle-del
branch
from
d1d60bd
to
f18f5e3
Compare
neethajohn
pushed a commit
that referenced
this pull request
Oct 26, 2021
…1837) Depends on #1787 What I did To reclaim reserved buffer. As the way to do it differs among vendors, the environment ASIC_VENDOR is passed to swss docker and will be loaded when buffermgrd starts. After that, buffermgrd will: Handle port admin down on Mellanox platform. Not apply lossless buffer PG to an admin-down port Remove lossless buffer PG (3-4) from a port when it is shut down. Readd lossless buffer PG (3-4) to a port when a port is started up. Why I did it To support reclaiming reserved buffer when a port is shut down on Mellanox platform. How I verified it Regression test and vs test. Signed-off-by: Stephen Sun <stephens@nvidia.com>
5 tasks
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
What I did Let's add swap memory setup support for sonic_installer command so it could run on devices with limited memory resources. How I did it Add the following new options to sonic_installer: * --skip-setup-swap: if present, will skip setup swap memory. * --swap-mem-size: this will change the swap memory size(the default swap size is 1024 MiB) * --total-mem-threshold: if the system total memory is less than the value passed to --total-mem-threshold(default 2048 MiB), sonic_installer will setup swap memory. * --available-mem-threshold: if the system available memory is less than the value passed to --available-mem-threshold(default 1200 MiB), sonic_installer will setup swap memory. Add class MutuallyExclusiveOption to check the mutually-exclusive relationship between options. Add class SWAPAllocator to support swap memory setup/remove functionalities. NOTE: when sonic_installer tries to setup swap, if the system disk free space is less than 4096 MiB, sonic_installer will not setup swap memory. How to verify it Run sonic_installer over devices with limited memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Handle
DELcommand forBUFFER_PGandBUFFER_QUEUEtable.Add vs test for
BUFFER_PGandBUFFER_QUEUEtable handlingSigned-off-by: Stephen Sun stephens@nvidia.com
Why I did it
How I verified it
Manually test.
Details if related