[macsec] Fix acl entry id in updateMACsecPort #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pterosaur
suggested changes
Jun 14, 2021
There was a problem hiding this comment.
I found there are same issues in other places using setMACsecFlowActive
Could you also help to fix them?
E.G.
https://github.com/Azure/sonic-swss/blob/a87ca108242701cf6e85aafa00fe35fde4f59b84/orchagent/macsecorch.cpp#L1111
https://github.com/Azure/sonic-swss/blob/a87ca108242701cf6e85aafa00fe35fde4f59b84/orchagent/macsecorch.cpp#L1697-L1702
That is true. I have submitted another commit to fix it. |
Pterosaur
approved these changes
Jun 15, 2021
4 tasks
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
* Fix acl entry id in updateMACsecPort * Extra fix to calling setMACsecFlowActive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
ACL entry Id should be used as first parameter of setMACsecFlowActive.
Why I did it
How I verified it
Details if related