[201911][acl] Handle uncaught exception in aclorch #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Allen <daall@microsoft.com>
qiluo-msft
reviewed
Mar 9, 2021
orchagent/aclorch.cpp
Outdated
| { | ||
| newRule = AclRule::makeShared(type, this, m_mirrorOrch, m_dTelOrch, rule_id, table_id, t); | ||
| } | ||
| catch (exception &e) |
There was a problem hiding this comment.
exception [](start = 19, length = 9)
exception type is too generic and possibly hide code bug. Could you list all possible excpetion types?
This comment is also applicable to master branch. So if you found better solution, let's start a PR on master first.
qiluo-msft
reviewed
Mar 9, 2021
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…net#1667) * Port Module and UT Added What I did HLD for Dump Utility: HLD. For More Info on adding new modules, Check this section in the HLD: MatchInfra Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
What I did Implemented vlan and vlan_member modules for debug dump utility. How I did it Used infrastructure and followed examples in sonic-net#1666 sonic-net#1667 sonic-net#1668 sonic-net#1669 sonic-net#1670 How to verify it On switch: dump state vlan <vlan_name> dump state vlan_member '<vlan_name|<member_name>' Unit test: pytest-3 dump_tests/module_tests/vlan_test.py (same test file covers both vlan and vlan_member)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen daall@microsoft.com
What I did
I added a
catchstatement to prevent orchagent from crashing if an invalid field combination is provided.Why I did it
#1486 added a
catchto prevent orchagent from crashing if an invalid field combination is provided, however this was not brought into 201911.How I verified it
Pass in something illegal like a rule for a
MIRRORtable with aPACKET_ACTIONand verify that orchagent reports an error to the syslog without crashing.Details if related