[flex-counters] Delay flex counters stats init for faster boot time #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stepanblyschak could u please help to review? |
stepanblyschak
previously approved these changes
Mar 2, 2021
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liat-grozovik
previously approved these changes
Mar 7, 2021
|
@shlomibitton please check test failure on PG counters. this is the only test i think relevant to your changes. |
|
/AzurePipleines run |
added 3 commits
March 29, 2021 18:24
Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
Fix 'test_pg_drop' to adapt new change Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
shlomibitton
dismissed stale reviews from liat-grozovik and stepanblyschak
via
2960e16
|
@stepanblyschak any comments? |
|
@stepanblyschak kindly please review. your approval is needed for such change. |
liat-grozovik
requested changes
Apr 4, 2021
| @@ -0,0 +1,83 @@ | |||
| import time | |||
There was a problem hiding this comment.
@shlomibitton could you please provide description of the flows to be tested in this unit test? it will help to ensure all cases are handled as part of the ut
There was a problem hiding this comment.
@liat-grozovik Added the test flow and description to the PR, please review.
liat-grozovik
previously approved these changes
Apr 4, 2021
stepanblyschak
suggested changes
Apr 5, 2021
stepanblyschak
approved these changes
Apr 5, 2021
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1646 in repo Azure/sonic-swss |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liat-grozovik
requested review from
qiluo-msft,
yxieca and
judyjoseph
and removed request for
qiluo-msft
|
@judyjoseph and @yxieca would you like to review this PR as well? |
yxieca
reviewed
Apr 8, 2021
|
@yxieca and @judyjoseph can you please review? |
yxieca
approved these changes
Apr 27, 2021
|
@shlomibitton there are merge conflicts w/ the 202012 branch, please submit a PR against 202012 for this change. |
lguohan
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Apr 29, 2021
[flex-counters] Delay flex counters stats init for faster boot time (sonic-net/sonic-swss#1646) [routeorch] Add support for blackhole routes (sonic-net/sonic-swss#1723) Update pool sizes during initialization from timer only (sonic-net/sonic-swss#1708) Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
|
4 tasks
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
[flex-counters] Delay flex counters stats init for faster boot time (sonic-net/sonic-swss#1646) [routeorch] Add support for blackhole routes (sonic-net/sonic-swss#1723) Update pool sizes during initialization from timer only (sonic-net/sonic-swss#1708) Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
[flex-counters] Delay flex counters stats init for faster boot time (sonic-net/sonic-swss#1646) [routeorch] Add support for blackhole routes (sonic-net/sonic-swss#1723) Update pool sizes during initialization from timer only (sonic-net/sonic-swss#1708) Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
…onic-net#1646) What I did Update flex counters DB with counters stats only when counters are enabled. As long as the polling counters are not enabled, flex counters information will stored internally on PortsOrch. Why I did it Creating flex counters objects on the DB will trigger 'SYNCD' to access the HW for query statistics capabilities. This HW access takes time and will be better to finish boot before doing this (mainly for fast-reboot but good to have in general). The flex counters are not crucial at boot time, we can delay it to the end of the boot process. How I verified it Reboot a switch and observer the flex counters DB populated after counters are enabled.
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
…t time (sonic-net#1646)" (sonic-net#1743) This reverts commit ee7a735.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shlomi Bitton shlomibi@nvidia.com
What I did
Update flex counters DB with counters stats only when counters are enabled.
As long as the polling counters are not enabled, flex counters information will stored internally on PortsOrch.
Why I did it
Creating flex counters objects on the DB will trigger 'SYNCD' to access the HW for query statistics capabilities.
This HW access takes time and will be better to finish boot before doing this (mainly for fast-reboot but good to have in general).
The flex counters are not crucial at boot time, we can delay it to the end of the boot process.
How I verified it
Reboot a switch and observer the flex counters DB populated after counters are enabled.
Details if related