Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue: "Failed to set default drop route to a new next hop #139" #145

Merged
merged 2 commits into from
Jan 11, 2017

Conversation

oleksandrivantsiv
Copy link
Collaborator

No description provided.

Based on Mellanox SAI implementation to change route action
from drop to forward packet action attr should be set before
next hop.
@oleksandrivantsiv
Copy link
Collaborator Author

oleksandrivantsiv commented Dec 19, 2016

This pull request depends on sonic-net/sonic-buildimage#142

@stcheng
Copy link
Contributor

stcheng commented Dec 19, 2016

So the SAI implementation will only work when the action is set to forward before the next hop ID is updated?

@oleksandrivantsiv
Copy link
Collaborator Author

oleksandrivantsiv commented Dec 20, 2016

Yes, this is limitation of MLNX SAI

@stcheng stcheng merged commit 677e926 into sonic-net:master Jan 11, 2017
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
if /host/old_config exists, the copy command will copy sonic directory
into /host/old_config
lukasstockner pushed a commit to genesiscloud/sonic-swss that referenced this pull request Apr 2, 2023
Fix crash in `show version` CLI command:

```
admin@sonic:~$ show version 
SONiC Software Version: SONiC.master.39-dirty-20201116.030425
Distribution: Debian 10.6
Kernel: 4.19.0-9-2-amd64
Build commit: e526d88
Build date: Mon Nov 16 06:49:50 UTC 2020
Built by: johnar@jenkins-worker-4Platform: x86_64-accton_wedge100bf_32x-r0
HwSKU: montara
ASIC: barefoot
Traceback (most recent call last):
  File "/usr/local/bin/decode-syseeprom", line 171, in <module>
    exit(main())
  File "/usr/local/bin/decode-syseeprom", line 47, in main
    t = class_('board', '','','')
  File "/usr/share/sonic/device/x86_64-accton_wedge100bf_32x-r0/plugins/eeprom.py", line 104, in __init__
    if self.eeprom_init():
  File "/usr/share/sonic/device/x86_64-accton_wedge100bf_32x-r0/plugins/eeprom.py", line 167, in eeprom_init
    new_e = eeprom_tlvinfo.TlvInfoDecoder.set_eeprom(self, "", [eeprom_params])
  File "/usr/local/lib/python2.7/dist-packages/sonic_eeprom/eeprom_tlvinfo.py", line 173, in set_eeprom
    (tlv_found, index) = self.get_tlv_index(new_tlvs, k)
  File "/usr/local/lib/python2.7/dist-packages/sonic_eeprom/eeprom_tlvinfo.py", line 454, in get_tlv_index
    if not self.is_valid_tlv(e[tlv_index:]):
  File "/usr/local/lib/python2.7/dist-packages/sonic_eeprom/eeprom_tlvinfo.py", line 255, in is_valid_tlv
    return (len(e) >= 2 and (2 + e[1] <= len(e)))
TypeError: unsupported operand type(s) for +: 'int' and 'str'
Serial Number:
............
```

Signed-off-by: Petro Bratash <petrox.bratash@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants