Get initial speed from ASIC DB #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sangita Maity sangitamaity0211@gmail.com
samaity
force-pushed
the
FIX_DEFAULT_BUFFER_PROFILE_LIST
branch
from
ed14ecb
to
73d4112
Compare
Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
|
retest vs please |
2 similar comments
|
retest vs please |
|
retest vs please |
daall
suggested changes
Aug 12, 2020
Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
|
retest vs please |
daall
approved these changes
Aug 12, 2020
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Allow ecn unit tests to run without root privileges **- How I did it** Included the UTILITIES_UNIT_TESTING' env variable also as one of the conditions to determine if the command needs root privileges for execution **- How to verify it** Ran utilities test using the command "python3 setup.py test" and ecn_test.py passed. Prior to the fix, most of the testcases were failing with the error 'Root privileged required for this operation'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sangita Maity sangitamaity0211@gmail.com
Co-authored-by: Vasant Patil vapatil@linkedin.com
What I did
Initialized the configured speed list by reading port speed from ASIC DB
sonic-buildimage #3910 PR has a dependency on it.
Otherwise
test_speedtest is getting failed and other few test cases are dependent on it.Why I did it
Since Speed is introduced in port_config.ini of VS platform, one of the buffer profiles is already created(speed 40G). Hence the test case is modified by reading port speed from ASIC DB. The list of speeds is [10G, 25G, 40G, 50G, 100G], the initial number of buffer profiles present is 4 (including the one created for 40G)
Test case walks through each speed and configures that speed on all the ports. Expects that a new buffer profile is created when a new speed is set on all ports. But note that since 40G profiles are already created, it expects no new buffer profile to be created when we set 40G on all ports.
Now, when we walk through the speed list, This is what happens
10G - yes a new profile is created
25G - yes, a new profile is created
40G - yes, a new profile is created. This is the problem!
Root cause: however, once the DPB feature gets in, the initial created buffer profile is NOT for 40G, instead it is for 100G.
Because we are setting the different speed for ports in platform.json
How I verified it
By running the VS test case