Bulk routes and next hop group members #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
… routes in bulker, flush the bulker and possibly collect some released nexthop groups
qiluo-msft
force-pushed
the
qiluo/bulkroute2020
branch
from
6643583
to
2364f8b
Compare
daall
reviewed
Apr 24, 2020
daall
reviewed
Apr 29, 2020
daall
previously approved these changes
Apr 29, 2020
|
i cannot find any unit test added for this feature. @qiluo-msft , what is your plan? |
Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
|
This pull request introduces 1 alert when merging 0506694 into 3829053 - view on LGTM.com new alerts:
|
|
This is a false alert. In reply to: 622630868 [](ancestors = 622630868) |
qiluo-msft
changed the title
lguohan
reviewed
May 4, 2020
daall
reviewed
May 4, 2020
daall
reviewed
May 4, 2020
|
This pull request introduces 1 alert when merging 73592f5 into e1a5e9a - view on LGTM.com new alerts:
|
daall
reviewed
May 5, 2020
|
This pull request introduces 1 alert when merging f35f530 into e1a5e9a - view on LGTM.com new alerts:
|
lguohan
approved these changes
May 5, 2020
|
Retest this please |
daall
approved these changes
May 5, 2020
|
retest this please |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…ller code will be the same as python2 (sonic-net#1238) The python2 behavior is not changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.