Remove the platform check for remove/add port action at init phase #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
lguohan
approved these changes
Jul 31, 2019
tonytitus
pushed a commit
to tonytitus/sonic-swss
that referenced
this pull request
Jul 31, 2019
…onic-net#1006) Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
) Changes to support the show interface status/description for multi ASIC - Add argparse intfutil script - Change the IntfDescription and IntfStatus classes to get the information from all namespaces. - Add changes to filter out the internal ports from display - Add support for -n and -d click options - Add unit test to test mulit asic commands Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
[SAI] Update SAI submodule to v1.5.1 * Defining new serdes attributes (sonic-net#1002) * Improve debug counter enums (sonic-net#1006) * Introduce buffer pool type SAI_BUFFER_POOL_TYPE_BOTH (sonic-net#986) Signed-off-by: Danny Allen <daall@microsoft.com> * Add redis and vs handler for serdes APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the platform check for remove/add port action at init phase.
Signed-off-by: Zhenggen Xu zxu@linkedin.com
What I did
Remove the platform check so all platform can remove/add port based on the configDB or port_config.ini during the init time.
Why I did it
BRCM is now supporting this. Also we should expect all platforms support this.
How I verified it
Along with sonic-buildimage PR: sonic-net/sonic-buildimage#3240, see the test results on that PR.
Details if related