Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vlanmgrd] interface is not removed from default dot1q bridge when executing "config vlan member del 1000 Ethernet100" #1068

Open
stepanblyschak opened this issue Sep 24, 2019 · 0 comments

Comments

@stepanblyschak
Copy link
Contributor

stepanblyschak commented Sep 24, 2019

From vlanmgr.cpp:

// The command should be generated as:
// /bin/bash -c '/sbin/bridge vlan del vid {{vlan_id}} dev {{port_alias}} &&
//               ( /sbin/bridge vlan show dev {{port_alias}} | /bin/grep -q None;
//               ret=$?; if [ $ret -eq 0 ]; then
//               /sbin/ip link set {{port_alias}} nomaster;
//               elif [ $ret -eq 1 ]; then exit 0;
//               else exit $ret; fi )'

Configuration: all ports in Vlan 1000

Execute:
admin@sonic:~$ sudo config vlan member del 1000 Ethernet124

Check output of the following command:

root@sonic:/# bridge vlan show dev Ethernet124
port    vlan ids

root@sonic:/# bridge vlan show dev Ethernet124 | grep -q None ; echo $?
1

Since return code is 1 the script decides not to remove interface from default dot1q bridge as there are other vlans configured, but they are not.

Expected behaviour:

If port was member of single vlan then remove it from default dot1q bridge.

oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this issue Mar 1, 2023
…net#1068)

The fix sonic-net#1067 is not enough. If docker user is non-root, set capability CAP_SYS_TIME for settimeofday success in syncd test, then test_watchdog_timer_clock_rollback can be run.

Co-authored-by: junhuazhai <junhuazhai@contoso.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant