Skip to content

Commit

Permalink
[qosorch] Dot1p map list initialization fix (#1746)
Browse files Browse the repository at this point in the history
- For DOT1P QOS map, the map list was not initialized correctly. So
"color" field in the key was sending garbage. Because of this, orchagent
serialization function is unable to translate and serialize the attribute
value properly and returns warning. During subsequent operation which comes
with a different garbage, this was treated as a different "color" and
syncd/SAI returns error saying "modification not implemented". This is
fixed by initializing the dotp1 map list attribute.

Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>
  • Loading branch information
vganesan-nokia authored and qiluo-msft committed Jun 11, 2021
1 parent f99abdc commit 386de71
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion orchagent/qosorch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ bool Dot1pToTcMapHandler::convertFieldValuesToAttributes(KeyOpFieldsValuesTuple
sai_qos_map_list_t dot1p_map_list;

// Allocated resources are freed in freeAttribResources() call
dot1p_map_list.list = new sai_qos_map_t[kfvFieldsValues(tuple).size()];
dot1p_map_list.list = new sai_qos_map_t[kfvFieldsValues(tuple).size()]();
int i = 0;
for (const auto &fv : kfvFieldsValues(tuple))
{
Expand Down

0 comments on commit 386de71

Please sign in to comment.