Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chassis][database][sonic-db-cli] Fix the instance database# start up failure on LC #866

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

mlok-nokia
Copy link
Contributor

@mlok-nokia mlok-nokia commented Mar 22, 2024

Why I did it

On multiasic LC, instance database# failed to start due to the sonic-db-cli -n asic# PING failed. soinc-db-cli -n asic0 PING failed which results in the /usr/bin/database.sh wait forever in the postStartAction(). Fixes sonic-net/sonic-buildimage#18395

How I did it

On multiasic LC, sonic-db-cli -n asic0 PING has been fixed/changed by PR #797. But when execute "sonic-db-cli -n asic0 PING" command, it will fail to ping the CHASSIS_STATE_DB and CHASSIS_APP_DB in the database-chassis on the supervisor card. The existing code uses db_name to check against
"redis_chassis.server" identify if it is for database-chassis is wrong. This commit uses variable "host" instead of db_name. This will fix the issue.

How to verify it

  1. Boot up the chassis, execuet " docker ps" to verify the instance database0 and database1 containers are up.
admin@ixre-egl-board40:~$ docker ps 
CONTAINER ID   IMAGE                                COMMAND                  CREATED          STATUS          PORTS     NAMES
d2dc397d420a   docker-macsec:latest                 "/usr/local/bin/supe?"   34 minutes ago   Up 34 minutes             macsec
fd60a96fcb67   docker-snmp:latest                   "/usr/local/bin/supe?"   6 hours ago      Up 6 hours                snmp
168cf9ae286d   docker-platform-monitor:latest       "/usr/bin/docker_ini?"   6 hours ago      Up 6 hours                pmon
9f1c69112fdb   docker-sonic-mgmt-framework:latest   "/usr/local/bin/supe?"   6 hours ago      Up 6 hours                mgmt-framework
01cb833ab7b6   docker-lldp:latest                   "/usr/bin/docker-lld?"   6 hours ago      Up 6 hours                lldp1
ec6a965669eb   docker-lldp:latest                   "/usr/bin/docker-lld?"   6 hours ago      Up 6 hours                lldp0
16dd25d29d7b   docker-lldp:latest                   "/usr/bin/docker-lld?"   6 hours ago      Up 6 hours                lldp
46ce9b823873   docker-sonic-gnmi:latest             "/usr/local/bin/supe?"   6 hours ago      Up 6 hours                gnmi
5f36560338e0   docker-fpm-frr:latest                "/usr/bin/docker_ini?"   6 hours ago      Up 6 hours                bgp1
3b1abe66e7a1   docker-fpm-frr:latest                "/usr/bin/docker_ini?"   6 hours ago      Up 6 hours                bgp0
85cd5b6cdd05   docker-router-advertiser:latest      "/usr/bin/docker-ini?"   6 hours ago      Up 6 hours                radv
ca8f79f69122   docker-teamd:latest                  "/usr/local/bin/supe?"   6 hours ago      Up 6 hours                teamd0
5fe4b55ac62e   docker-syncd-brcm-dnx:latest         "/usr/local/bin/supe?"   6 hours ago      Up 6 hours                syncd1
81b6ef493818   docker-syncd-brcm-dnx:latest         "/usr/local/bin/supe?"   6 hours ago      Up 6 hours                syncd0
4e32dd244b65   docker-teamd:latest                  "/usr/local/bin/supe?"   6 hours ago      Up 6 hours                teamd1
4f83bee7ffba   docker-orchagent:latest              "/usr/bin/docker-ini?"   6 hours ago      Up 6 hours                swss0
4e2c047effa8   docker-orchagent:latest              "/usr/bin/docker-ini?"   6 hours ago      Up 6 hours                swss1
0b6d7e742c0f   docker-eventd:latest                 "/usr/local/bin/supe?"   6 hours ago      Up 6 hours                eventd
5c77bae968e0   docker-database:latest               "/usr/local/bin/dock?"   6 hours ago      Up 6 hours                database1
d4616de64435   docker-database:latest               "/usr/local/bin/dock?"   6 hours ago      Up 6 hours                database0
27403c8acffa   docker-database:latest               "/usr/local/bin/dock?"   6 hours ago      Up 6 hours                database

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Master branch

…o start up in LC

Signed-off-by: mlok <marty.lok@nokia.com>
@mlok-nokia
Copy link
Contributor Author

@rlhui @judyjoseph This PR address the instance database# fail to start on multiasic LC. Please review it

@lguohan lguohan requested a review from liuh-80 March 22, 2024 21:28
@mlok-nokia
Copy link
Contributor Author

@liuh-80 Please help to review this PR.

@qiluo-msft qiluo-msft requested a review from judyjoseph March 27, 2024 18:15
@mlok-nokia
Copy link
Contributor Author

@judyjoseph Please help to review and merge this PR. Thanks

@judyjoseph
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[master][chassis][multiasic] Linecard Asic database# start failed due to sonic-db-cli -n asic0 PING failed
6 participants