Fix common path issue in profileprovider.cpp #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganglyu
approved these changes
Feb 22, 2023
zbud-msft
approved these changes
Feb 22, 2023
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Feb 23, 2023
Update sonic-swss-common submodule pointer to include the following: * 565ad4b Fix common path issue ([sonic-net#751](sonic-net/sonic-swss-common#751)) * 3352881 Prevent sonic-db-cli generate core dump ([sonic-net#749](sonic-net/sonic-swss-common#749)) * 43cadec Add ProfileProvider class to support read profile config from PROFILE_DB. ([sonic-net#683](sonic-net/sonic-swss-common#683)) * 8b09f90 Update path to sairedis tests ([sonic-net#747](sonic-net/sonic-swss-common#747)) * 85f3776 Non recursive automake and Debian packaging changes ([sonic-net#700](sonic-net/sonic-swss-common#700)) Signed-off-by: dprital <drorp@nvidia.com>
8 tasks
lguohan
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Feb 27, 2023
Update sonic-swss-common submodule pointer to include the following: * 565ad4b Fix common path issue ([#751](sonic-net/sonic-swss-common#751)) * 3352881 Prevent sonic-db-cli generate core dump ([#749](sonic-net/sonic-swss-common#749)) * 43cadec Add ProfileProvider class to support read profile config from PROFILE_DB. ([#683](sonic-net/sonic-swss-common#683)) * 8b09f90 Update path to sairedis tests ([#747](sonic-net/sonic-swss-common#747)) * 85f3776 Non recursive automake and Debian packaging changes ([#700](sonic-net/sonic-swss-common#700)) Signed-off-by: dprital <drorp@nvidia.com>
saiarcot895
added a commit
to saiarcot895/sonic-buildimage
that referenced
this pull request
Mar 7, 2023
Update sonic-swss-common submodule pointer to include the following: * 565ad4b Fix common path issue ([sonic-net#751](sonic-net/sonic-swss-common#751)) * 3352881 Prevent sonic-db-cli generate core dump ([sonic-net#749](sonic-net/sonic-swss-common#749)) * 43cadec Add ProfileProvider class to support read profile config from PROFILE_DB. ([sonic-net#683](sonic-net/sonic-swss-common#683)) * 8b09f90 Update path to sairedis tests ([sonic-net#747](sonic-net/sonic-swss-common#747)) * 85f3776 Non recursive automake and Debian packaging changes ([sonic-net#700](sonic-net/sonic-swss-common#700)) This is a reland of sonic-net#13950, with the debug image build fix. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
8 tasks
AntonHryshchuk
added a commit
to AntonHryshchuk/sonic-buildimage
that referenced
this pull request
Mar 8, 2023
Update sonic-swss-common submodule pointer to include the following: * 06ffb51 Define ACL_TABLE and ACL_RULE table in STATE_DB ([sonic-net#748](sonic-net/sonic-swss-common#748)) * 1b369ab [ci] Fix apt-get install unable locate package issue. ([sonic-net#753](sonic-net/sonic-swss-common#753)) * 619d4ec Improve unit test for go wrapper ([sonic-net#752](sonic-net/sonic-swss-common#752)) * 565ad4b Fix common path issue ([sonic-net#751](sonic-net/sonic-swss-common#751)) * 3352881 Prevent sonic-db-cli generate core dump ([sonic-net#749](sonic-net/sonic-swss-common#749)) * 43cadec Add ProfileProvider class to support read profile config from PROFILE_DB. ([sonic-net#683](sonic-net/sonic-swss-common#683)) * 8b09f90 Update path to sairedis tests ([sonic-net#747](sonic-net/sonic-swss-common#747)) * 85f3776 Non recursive automake and Debian packaging changes ([sonic-net#700](sonic-net/sonic-swss-common#700)) Signed-off-by: AntonHryshchuk <antonh@nvidia.com>
xumia
pushed a commit
to xumia/sonic-buildimage-1
that referenced
this pull request
Mar 10, 2023
Update sonic-swss-common submodule pointer to include the following: * 565ad4b Fix common path issue ([sonic-net#751](sonic-net/sonic-swss-common#751)) * 3352881 Prevent sonic-db-cli generate core dump ([sonic-net#749](sonic-net/sonic-swss-common#749)) * 43cadec Add ProfileProvider class to support read profile config from PROFILE_DB. ([sonic-net#683](sonic-net/sonic-swss-common#683)) * 8b09f90 Update path to sairedis tests ([sonic-net#747](sonic-net/sonic-swss-common#747)) * 85f3776 Non recursive automake and Debian packaging changes ([sonic-net#700](sonic-net/sonic-swss-common#700)) Signed-off-by: dprital <drorp@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
sonic-gnmi will break if any header file contains 'common' in path
How I did it
Fix common path issue in profileprovider.cpp
How to verify it
Pass all UT and E2E test cases.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Fix common path issue in profileprovider.cpp
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)