Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decorator for Yang default value. #713

Merged
merged 6 commits into from
Nov 22, 2022

Conversation

liuh-80
Copy link
Contributor

@liuh-80 liuh-80 commented Nov 21, 2022

Why I did it

Support sonic-swss-common read Yang model defaut value.

How I did it

Add decorator for Yang default value.

How to verify it

Add new UT to cover new decorate code.
Pass all UT and E2E test cases.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Add decorator for Yang default value.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@liuh-80 liuh-80 marked this pull request as ready for review November 21, 2022 06:39
@liuh-80 liuh-80 requested a review from qiluo-msft November 21, 2022 06:39
@qiluo-msft
Copy link
Contributor

#include <string.h>

Did you delete this file by accident?


Refers to: common/dbconnector.cpp:1 in f527d74. [](commit_id = f527d74, deletion_comment = True)

@liuh-80
Copy link
Contributor Author

liuh-80 commented Nov 21, 2022

#include <string.h>

Did you delete this file by accident?

Refers to: common/dbconnector.cpp:1 in f527d74. [](commit_id = f527d74, deletion_comment = True)

Fixed, this is not file delete, it's a file mode change, I will create another PT to fix the file mode issue in this repo.

@liuh-80 liuh-80 merged commit bfe123e into sonic-net:master Nov 22, 2022
@liuh-80 liuh-80 deleted the dev/liuh/default-value-decorate branch November 22, 2022 01:42
StormLiangMS pushed a commit to StormLiangMS/sonic-swss-common that referenced this pull request Dec 11, 2022
#### Why I did it
Support sonic-swss-common read Yang model defaut value.

#### How I did it
Add decorator for Yang default value.

#### How to verify it
Add new UT to cover new decorate code.
Pass all UT and E2E test cases.

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111

#### Description for the changelog
Add decorator for Yang default value.

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on https://github.com/Azure/SONiC/wiki/Configuration.
-->

#### A picture of a cute animal (not mandatory but encouraged)
StormLiangMS added a commit that referenced this pull request Dec 11, 2022
Cherry-pick from master branch

f312634 - Install swsscommon.i with libswsscommon-dev (Install swsscommon.i with libswsscommon-dev #717) (6 minutes ago) [ganglv]
61b7888 - Use SWIGPYTHON to improve SWIG for GO wrapper. (Use SWIGPYTHON to improve SWIG for GO wrapper. #714) (6 minutes ago) [ganglv]
1c10dac - Add decorator for Yang default value. (Add decorator for Yang default value.  #713) (6 minutes ago) [Hua Liu]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants