[select] break the select loop if interrupt_on_signal flag is set #624

stepanblyschak · 2022-05-27T11:01:30Z

Signed-off-by: Stepan Blyschak stepanb@nvidia.com

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

stepanblyschak · 2022-05-30T07:36:16Z

/azpw run

mssonicbld · 2022-05-30T07:36:17Z

/AzurePipelines run

azure-pipelines · 2022-05-30T07:36:29Z

Azure Pipelines successfully started running 1 pipeline(s).

stepanblyschak · 2022-05-30T11:59:17Z

/azpw run

mssonicbld · 2022-05-30T11:59:19Z

/AzurePipelines run

azure-pipelines · 2022-05-30T11:59:31Z

Azure Pipelines successfully started running 1 pipeline(s).

stepanblyschak · 2022-05-30T16:36:03Z

/azpw run

mssonicbld · 2022-05-30T16:36:05Z

/AzurePipelines run

azure-pipelines · 2022-05-30T16:36:16Z

Azure Pipelines successfully started running 1 pipeline(s).

stepanblyschak · 2022-05-30T20:50:13Z

/azpw run

mssonicbld · 2022-05-30T20:50:15Z

/AzurePipelines run

azure-pipelines · 2022-05-30T20:50:27Z

Azure Pipelines successfully started running 1 pipeline(s).

kcudnik · 2022-05-31T13:18:03Z

what is actual motivation for this change?

stepanblyschak · 2022-06-08T15:55:57Z

/azpw run

mssonicbld · 2022-06-08T15:55:59Z

/AzurePipelines run

azure-pipelines · 2022-06-08T15:56:11Z

Azure Pipelines successfully started running 1 pipeline(s).

stepanblyschak · 2022-06-08T16:02:55Z

@kcudnik This is to fix #603

stepanblyschak · 2022-06-08T20:22:04Z

/azpw run

mssonicbld · 2022-06-08T20:22:05Z

/AzurePipelines run

azure-pipelines · 2022-06-08T20:22:17Z

Azure Pipelines successfully started running 1 pipeline(s).

stepanblyschak · 2022-06-09T08:03:34Z

/azpw run

mssonicbld · 2022-06-09T08:03:36Z

/AzurePipelines run

azure-pipelines · 2022-06-09T08:03:48Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2022-06-14T07:11:15Z

@qiluo-msft could you please help to review or suggest a reviewer ?

azure-pipelines · 2022-06-27T07:27:55Z

Azure Pipelines successfully started running 1 pipeline(s).

stepanblyschak · 2022-06-27T13:59:23Z

Looks like the built VS image is broken:

root@r-sonic-vs-006:~# docker ps
CONTAINER ID   IMAGE                                                COMMAND                  CREATED         STATUS         PORTS     NAMES
254b190e0e7d   docker-sonic-vs:Azure.sonic-swss-common.20220627.4   "/usr/local/bin/supe…"   4 minutes ago   Up 4 minutes             vs
277ed3813ef0   debian                                               "bash"                   5 minutes ago   Up 5 minutes             sw
root@r-sonic-vs-006:~# docker exec -it vs bash
root@277ed3813ef0:/# cat /etc/sonic/sonic_version.yml
---
build_version: ''
asic_type: vs
commit_id: '9d5ca72b8'
branch: 'master'
release: 'none'
build_date: Sun Jun 26 15:08:01 UTC 2022
build_number: 114767
built_by: AzDevOps@sonic-build-workers-001OP8
root@277ed3813ef0:/# tail /var/log/syslog
Jun 27 13:54:08.190264 277ed3813ef0 INFO #/supervisord: redis-server 104:M 27 Jun 2022 13:54:08.190 # WARNING overcommit_memory is set to 0! Background save may fail under low memory condition. To fix this issue add 'vm.overcommit_memory = 1' to /etc/sysctl.conf and then reboot or run the command 'sysctl vm.overcommit_memory=1' for this to take effect.
Jun 27 13:54:08.190582 277ed3813ef0 INFO #/supervisord: redis-server 104:M 27 Jun 2022 13:54:08.190 # WARNING you have Transparent Huge Pages (THP) support enabled in your kernel. This will create latency and memory usage issues with Redis. To fix this issue run the command 'echo never > /sys/kernel/mm/transparent_hugepage/enabled' as root, and add it to your /etc/rc.local in order to retain the setting after a reboot. Redis must be restarted after THP is disabled.
Jun 27 13:54:08.191206 277ed3813ef0 INFO #/supervisord: redis-server 104:M 27 Jun 2022 13:54:08.191 * Ready to accept connections
Jun 27 13:54:08.191534 277ed3813ef0 INFO #/supervisord: redis-server 104:M 27 Jun 2022 13:54:08.191 * The server is now ready to accept connections at /var/run/redis/redis.sock
Jun 27 13:54:09.195817 277ed3813ef0 INFO #supervisord 2022-06-27 13:54:09,193 INFO success: redis-server entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
Jun 27 13:54:09.197087 277ed3813ef0 INFO #/supervisord: start.sh redis-server: started
Jun 27 13:54:09.824316 277ed3813ef0 INFO #/update_chassisdb_config: remove chassis_db from config file /var/run/redis/sonic-db/database_config.json.tmp
Jun 27 13:54:09.836892 277ed3813ef0 INFO #/supervisord: start.sh /usr/bin/configdb-load.sh: line 4: sonic-db-cli: command not found
Jun 27 13:58:17.722624 277ed3813ef0 INFO #supervisord 2022-06-27 13:58:17,721 INFO reaped unknown pid 164 (terminated by SIGTERM)
Jun 27 13:58:17.725611 277ed3813ef0 INFO #supervisord 2022-06-27 13:58:17,724 INFO reaped unknown pid 358 (terminated by SIGTERM)

@qiluo-msft Looks like every PR in sonic-swss-common has this problem

stepanblyschak · 2022-06-28T11:39:26Z

/azpw run

mssonicbld · 2022-06-28T11:39:29Z

/AzurePipelines run

azure-pipelines · 2022-06-28T11:39:42Z

Azure Pipelines successfully started running 1 pipeline(s).

…ignal

stepanblyschak · 2022-06-29T11:20:06Z

Didn't change the logic in last update, just merged the master without conflicts and now sairedis build is not passing:

[  FAILED  ] 2 tests, listed below:
[  FAILED  ] LegacyFdbEntry.fdb_entry_get
[  FAILED  ] Legacy.switch_get

stepanblyschak · 2022-06-29T11:20:11Z

/azpw run

mssonicbld · 2022-06-29T11:20:15Z

/AzurePipelines run

azure-pipelines · 2022-06-29T11:20:29Z

Azure Pipelines successfully started running 1 pipeline(s).

stepanblyschak · 2022-06-29T15:58:28Z

Now it is the other way around, VS tests are failing but SAIRedis for some reason passed, retrying

stepanblyschak · 2022-06-29T15:58:37Z

/azpw run

mssonicbld · 2022-06-29T15:58:40Z

/AzurePipelines run

azure-pipelines · 2022-06-29T16:00:23Z

Azure Pipelines successfully started running 1 pipeline(s).

stepanblyschak · 2022-06-29T20:50:11Z

These two tests are failing now:

test_drop_counters.py::TestDropCounters::test_add_remove_port FAILED     [ 20%]
test_drop_counters.py::TestDropCounters::test_createAndDeleteMultipleCounters FAILED [ 20%]

However they pass locally on the same Azure.sonic-swss-common.20220629.6:

root@r-sonic-vs-005:~/sonic-swss/tests# py.test test_drop_counters.py -v --imgname=docker-sonic-vs:Azure.sonic-swss-common.20220629.6                                                                                                      ================================================ test session starts =================================================                                                                                                                     platform linux -- Python 3.8.10, pytest-6.2.4, py-1.10.0, pluggy-0.13.1 -- /usr/bin/python3                                                                                                                                                cachedir: .pytest_cache                                                                                                                                                                                                                    rootdir: /root/sonic-swss/tests                                                                                                                                                                                                            plugins: flaky-3.7.0                                                                                                                                                                                                                       collected 17 items                                                                                                                                                                                                                                                                                                                                                                                                                                                                    test_drop_counters.py::TestDropCounters::test_deviceCapabilitiesTablePopulated PASSED                          [  5%]                                                                                                                      test_drop_counters.py::TestDropCounters::test_flexCounterGroupInitialized PASSED                               [ 11%]                                                                                                                      test_drop_counters.py::TestDropCounters::test_createAndRemoveDropCounterBasic PASSED                           [ 17%]                                                                                                                      test_drop_counters.py::TestDropCounters::test_createAndRemoveDropCounterReversed PASSED                        [ 23%]                                                                                                                      test_drop_counters.py::TestDropCounters::test_createCounterWithInvalidCounterType PASSED                       [ 29%]                                                                                                                      test_drop_counters.py::TestDropCounters::test_createCounterWithInvalidDropReason PASSED                        [ 35%]                                                                                                                      test_drop_counters.py::TestDropCounters::test_addReasonToInitializedCounter PASSED                             [ 41%]                                                                                                                      test_drop_counters.py::TestDropCounters::test_removeReasonFromInitializedCounter PASSED                        [ 47%]                                                                                                                      test_drop_counters.py::TestDropCounters::test_removeAllDropReasons PASSED                                      [ 52%]                                                                                                                      test_drop_counters.py::TestDropCounters::test_addDropReasonMultipleTimes PASSED                                [ 58%]
test_drop_counters.py::TestDropCounters::test_addInvalidDropReason PASSED                                      [ 64%]
test_drop_counters.py::TestDropCounters::test_removeDropReasonMultipleTimes PASSED                             [ 70%]
test_drop_counters.py::TestDropCounters::test_removeNonexistentDropReason PASSED                               [ 76%]
test_drop_counters.py::TestDropCounters::test_removeInvalidDropReason PASSED                                   [ 82%]
test_drop_counters.py::TestDropCounters::test_add_remove_port PASSED                                           [ 88%]
test_drop_counters.py::TestDropCounters::test_createAndDeleteMultipleCounters PASSED                           [ 94%]
test_drop_counters.py::test_nonflaky_dummy PASSED                                                              [100%]

Looks like they are not stable. Will retry.

stepanblyschak · 2022-06-29T20:50:23Z

/azpw run

mssonicbld · 2022-06-29T20:50:26Z

/AzurePipelines run

azure-pipelines · 2022-06-29T20:50:40Z

Azure Pipelines successfully started running 1 pipeline(s).

stepanblyschak · 2022-07-01T10:45:53Z

Request to cherry-pick to 202205 branch

…s set (sonic-net#624) Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

…s set (#624) (#642) Signed-off-by: Stepan Blyschak <stepanb@nvidia.com> Co-authored-by: Hua Liu <58683130+liuh-80@users.noreply.github.com>

…nic-net#624)

Junchao-Mellanox · 2022-08-23T09:12:25Z

Hi @qiluo-msft , could you help cherry pick to 202205?

qiluo-msft · 2022-08-24T23:45:45Z

@yxieca will be the right picker for 202205.

…nic-net#624)

[select] break the select loop if interrupt_on_signal flag is set

44c1e4e

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

stepanblyschak marked this pull request as draft May 27, 2022 11:27

stepanblyschak added 2 commits May 30, 2022 00:30

make test work on python2

95e3fd2

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

move the test

84f2923

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

stepanblyschak marked this pull request as ready for review May 31, 2022 09:56

stepanblyschak mentioned this pull request May 31, 2022

Fix hostcfgd does not react to SIGINT issue. sonic-net/sonic-buildimage#10977

Closed

6 tasks

Merge branch 'master' of github.com:azure/sonic-swss-common into py-s…

b520d3a

…ignal

qiluo-msft merged commit 10cd834 into sonic-net:master Jun 30, 2022

stepanblyschak pushed a commit to stepanblyschak/sonic-swss-common that referenced this pull request Jul 1, 2022

[202111] [select] break the select loop if interrupt_on_signal flag i…

f4f3bfa

…s set (sonic-net#624) Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

stepanblyschak mentioned this pull request Jul 1, 2022

[202111] [select] break the select loop if interrupt_on_signal flag is set #642

Merged

itamar-talmon pushed a commit to itamar-talmon/sonic-swss-common that referenced this pull request Jul 19, 2022

[select] break the select loop if interrupt_on_signal flag is set (so…

3bb1af2

…nic-net#624)

Junchao-Mellanox added the Request for 202205 Branch label Aug 23, 2022

Junchao-Mellanox pushed a commit to Junchao-Mellanox/sonic-swss-common that referenced this pull request Aug 25, 2022

[select] break the select loop if interrupt_on_signal flag is set (so…

5f340d9

…nic-net#624)

yxieca pushed a commit that referenced this pull request Aug 26, 2022

[select] break the select loop if interrupt_on_signal flag is set (#624)

af80c12

yxieca added the Included in 202205 Branch label Aug 26, 2022

[select] break the select loop if interrupt_on_signal flag is set #624

[select] break the select loop if interrupt_on_signal flag is set #624

Conversation

stepanblyschak commented May 27, 2022

stepanblyschak commented May 30, 2022

mssonicbld commented May 30, 2022

azure-pipelines bot commented May 30, 2022

stepanblyschak commented May 30, 2022

mssonicbld commented May 30, 2022

azure-pipelines bot commented May 30, 2022

stepanblyschak commented May 30, 2022

mssonicbld commented May 30, 2022

azure-pipelines bot commented May 30, 2022

stepanblyschak commented May 30, 2022

mssonicbld commented May 30, 2022

azure-pipelines bot commented May 30, 2022

kcudnik commented May 31, 2022

stepanblyschak commented Jun 8, 2022

mssonicbld commented Jun 8, 2022

azure-pipelines bot commented Jun 8, 2022

stepanblyschak commented Jun 8, 2022

stepanblyschak commented Jun 8, 2022

mssonicbld commented Jun 8, 2022

azure-pipelines bot commented Jun 8, 2022

stepanblyschak commented Jun 9, 2022

mssonicbld commented Jun 9, 2022

azure-pipelines bot commented Jun 9, 2022

liat-grozovik commented Jun 14, 2022

azure-pipelines bot commented Jun 27, 2022

stepanblyschak commented Jun 27, 2022 • edited Loading

stepanblyschak commented Jun 28, 2022

mssonicbld commented Jun 28, 2022

azure-pipelines bot commented Jun 28, 2022

stepanblyschak commented Jun 29, 2022

stepanblyschak commented Jun 29, 2022

mssonicbld commented Jun 29, 2022

azure-pipelines bot commented Jun 29, 2022

stepanblyschak commented Jun 29, 2022

stepanblyschak commented Jun 29, 2022

mssonicbld commented Jun 29, 2022

azure-pipelines bot commented Jun 29, 2022

stepanblyschak commented Jun 29, 2022

stepanblyschak commented Jun 29, 2022

mssonicbld commented Jun 29, 2022

azure-pipelines bot commented Jun 29, 2022

stepanblyschak commented Jul 1, 2022

Junchao-Mellanox commented Aug 23, 2022

qiluo-msft commented Aug 24, 2022

stepanblyschak commented Jun 27, 2022 •

edited

Loading