Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DBInterface blocking operations #505

Merged
merged 2 commits into from
Jul 22, 2021

Conversation

qiluo-msft
Copy link
Contributor

@qiluo-msft qiluo-msft commented Jul 21, 2021

Fixes sonic-net/sonic-buildimage#8202

  • Fix pubsub channel timeout unit
  • Reset context err before next redisGetReply, otherwise later redisGetReply early return on no data, and burn CPU core in a loop.

ref: redis/hiredis#332

redisGetReply

Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
@qiluo-msft qiluo-msft merged commit a90529f into sonic-net:master Jul 22, 2021
@qiluo-msft qiluo-msft deleted the qiluo/hotloop branch July 22, 2021 09:18
qiluo-msft added a commit that referenced this pull request Jul 28, 2021
Fixes sonic-net/sonic-buildimage#8202
- Fix pubsub channel timeout unit
- Reset context err before next redisGetReply, otherwise later redisGetReply early return on no data, and burn CPU core in a loop.
@dgsudharsan
Copy link
Collaborator

Required for 202106

judyjoseph pushed a commit that referenced this pull request Aug 17, 2021
Fixes sonic-net/sonic-buildimage#8202
- Fix pubsub channel timeout unit
- Reset context err before next redisGetReply, otherwise later redisGetReply early return on no data, and burn CPU core in a loop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SNMP-SUBAGENT] [202012] Observed a unusual spike in CPU usage because of blocking=True argument
4 participants