Addition of host-resource subagents to return supported OIDs in HOST-… #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did ...
Added host resource subagents in src/sonic-snmpagent to return the data for the supported OIDs in HOST-RESOURCES-V2-MIB
The OIDs can be found here: https://mibbrowser.online/mibdb_search.php?mib=HOST-RESOURCES-V2-MIB
In addition, the REDIS entry "MOUNT_POINTS | LastUpdateTime" shows up in the SNMP walk, when it should not, because there is no associated OID entry for this value. This entry was added for logging and consistency purposes.
How I did it ...
Added classes hrFSTable & hrStorageTable to handle the filesystem related attributes for SNMP GET request
How I verified it ...
Added unit tests to verify the newly added OID implementation. The steps to run the unit tests can be found in azure-pipelines.yml in the sonic-snmpagent repo
Description ...
Add SNMP GET support and related unit tests for filesystem and total disk usage table in ietf rfc2790 MIB
Signed-off-by: Rakshintha Prasad [rakprasa@cisco.com]