Updating SNMP implementation to handle change of PSU Keys #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 11, 2024
Open
gechiang
approved these changes
Jun 3, 2024
|
let's fix this and rerun, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Modified snmp implementation of Cisco MIB to use updated format for psu keys instead of index of PSU
- How I did it
Used a consistently sorted list of keys to allow for the modified statedb key naming for psus
- How to verify it
Ran the associated sonic-mgmt tests for PSUs (phy_entity and snmp_psu)
- Description for the changelog
Modifies SNMP implementation of Cisco PSUs to use key names instead of simple indexing
Related PRs:
sonic-net/sonic-mgmt#11944
sonic-net/sonic-utilities#3208
sonic-net/sonic-platform-daemons#446