Don't cache the vlan-id if it is not valid from DB #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
qiluo-msft
approved these changes
Nov 14, 2022
7 tasks
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Nov 16, 2022
#### Why I did it Update sonic-snmpagent ubmodule pointer to include the following: * bf6cd4c Remove error logging on "failed in fdb_vlanmac" ([#272](sonic-net/sonic-snmpagent#272)) * 05f2a28 Remove LOGLEVEL DB since is no longer used ([#271](sonic-net/sonic-snmpagent#271)) * 06299e1 Don't cache the vlan-id if it is not valid from DB ([#273](sonic-net/sonic-snmpagent#273)) * 8a515f2 Install libyang to azure pipeline ([#268](sonic-net/sonic-snmpagent#268)) #### How I did it Advance sonic-snmpagent pointer
qiluo-msft
pushed a commit
that referenced
this pull request
Nov 17, 2022
Don't cache the vlan-id if it is not valid from DB **- What I did** Avoid caching the vlan-id with invalid value. **- How I did it** Add a check in code so if vlan-id is not valid, don't cache it.
richardyu-ms
pushed a commit
to richardyu-ms/sonic-buildimage
that referenced
this pull request
Nov 18, 2022
#### Why I did it Update sonic-snmpagent ubmodule pointer to include the following: * bf6cd4c Remove error logging on "failed in fdb_vlanmac" ([sonic-net#272](sonic-net/sonic-snmpagent#272)) * 05f2a28 Remove LOGLEVEL DB since is no longer used ([sonic-net#271](sonic-net/sonic-snmpagent#271)) * 06299e1 Don't cache the vlan-id if it is not valid from DB ([sonic-net#273](sonic-net/sonic-snmpagent#273)) * 8a515f2 Install libyang to azure pipeline ([sonic-net#268](sonic-net/sonic-snmpagent#268)) #### How I did it Advance sonic-snmpagent pointer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't cache the vlan-id if it is not valid from DB
Signed-off-by: Zhenggen Xu zxu@linkedin.com
- What I did
Avoid caching the vlan-id with invalid value.
- How I did it
Add a check in code so if vlan-id is not valid, don't cache it.
- How to verify it
- Description for the changelog