Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SAI_SWITCH_ATTR_AVAILABLE_IPMC_ENTRY needed by CRM #756

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Add support for SAI_SWITCH_ATTR_AVAILABLE_IPMC_ENTRY needed by CRM #756

merged 1 commit into from
Jan 7, 2021

Conversation

PrabhuSreenivasan
Copy link
Contributor

Signed-off-by: Prabhu Sreenivasan prabhu.sreenivasan@broadcom.com

This change is required for sonic-net/sonic-swss#1511

@PrabhuSreenivasan
Copy link
Contributor Author

retest vs please'

@PrabhuSreenivasan
Copy link
Contributor Author

retest vs please

kcudnik
kcudnik previously approved these changes Jan 3, 2021
View reviewed changes
Copy link
Collaborator

@kcudnik kcudnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve failed build if related

@PrabhuSreenivasan
Copy link
Contributor Author

retest this please

@PrabhuSreenivasan
Copy link
Contributor Author

How can we retest Azure.sonic-sairedis ?

@PrabhuSreenivasan
Copy link
Contributor Author

new vs failures seem unrelated.

@kcudnik
Copy link
Collaborator

kcudnik commented Jan 5, 2021

4 failing tests on vs are ok, there is work to fix them, but about azure sonic build was not found, not sure why

@PrabhuSreenivasan
Copy link
Contributor Author

PrabhuSreenivasan commented Jan 5, 2021 •
edited
Loading

4 failing tests on vs are ok, there is work to fix them, but about azure sonic build was not found, not sure why

Azure.sonic-sairedis build (20201225) was done 11 days back and may have got deleted by system. How can we trigger a rebuild?

@kcudnik
Copy link
Collaborator

kcudnik commented Jan 5, 2021 •
edited
Loading

retest this please is not triggering Azure.sonic-sairedis
please add some dummy commit, or force push branch again

@PrabhuSreenivasan
Add support for SAI_SWITCH_ATTR_AVAILABLE_IPMC_ENTRY needed by CRM
c6a03d0 
Signed-off-by: Prabhu Sreenivasan <prabhu.sreenivasan@broadcom.com>
@PrabhuSreenivasan
Copy link
Contributor Author

retest vs please

@kcudnik
Copy link
Collaborator

kcudnik commented Jan 6, 2021 

E       RuntimeError: Sonic database config file doesn't exist at /var/run/redis/sonic-db/database_config.json

something changed with environment

@kcudnik
Copy link
Collaborator

kcudnik commented Jan 6, 2021

@daall Are you aware of any env changes that could lead to this test failures ?

@daall
Copy link
Contributor

daall commented Jan 6, 2021

@daall Are you aware of any env changes that could lead to this test failures ?

This looks like the issue where the database_config.json is not being installed correctly, @qiluo-msft can you please take a look?

@qiluo-msft
Copy link
Contributor

Retest vs please

@kcudnik
Copy link
Collaborator

kcudnik commented Jan 6, 2021

"Retest vs please" solution for all the problems on all PR's XD

@kcudnik kcudnik merged commit 9ecc541 into sonic-net:master Jan 7, 2021
@PrabhuSreenivasan PrabhuSreenivasan deleted the crm_ipmc_nat branch January 8, 2021 05:54
@daall daall mentioned this pull request Jan 19, 2021
Closed
4 tasks
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
@PrabhuSreenivasan
Add support for SAI_SWITCH_ATTR_AVAILABLE_IPMC_ENTRY needed by CRM (s…
c221af5 
…onic-net#756)

Signed-off-by: Prabhu Sreenivasan <prabhu.sreenivasan@broadcom.com>

Co-authored-by: Prabhu Sreenivasan <ps944501@xl-sj1-31.lvn.broadcom.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcudnik kcudnik kcudnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PrabhuSreenivasan @kcudnik @daall @qiluo-msft