Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flex counter] add rif plugins #562

Merged
merged 5 commits into from
Jun 10, 2020
Merged

[flex counter] add rif plugins #562

merged 5 commits into from
Jun 10, 2020

Conversation

mykolaf
Copy link
Contributor

@mykolaf mykolaf commented Feb 19, 2020

According to HLD

Depends on sonic-swws-common #330

Signed-off-by: Mykola Faryma mykolaf@mellanox.com

@abdosi abdosi marked this pull request as ready for review March 29, 2020 06:28
abdosi
abdosi previously approved these changes Mar 29, 2020
@daall daall requested a review from kcudnik March 30, 2020 17:55
@kcudnik
Copy link
Collaborator

kcudnik commented Mar 30, 2020

ca you resolve conflicts ?

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
@liat-grozovik
Copy link
Collaborator

retest this please

@liat-grozovik
Copy link
Collaborator

@abdosi where do we stands with this review? can it be approved?

@kcudnik
Copy link
Collaborator

kcudnik commented Apr 19, 2020

You have compilation errors:
FlexCounter.cpp:871:27: error: 'RIF_PLUGIN_FIELD' was not declared in this scope
12:02:50 else if (field == RIF_PLUGIN_FIELD)

@mykolaf
Copy link
Contributor Author

mykolaf commented Apr 21, 2020

@kcudnik The error is caused by dependency sonic-net/sonic-swss-common#330
which is not yet merged

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
syncd/FlexCounter.cpp Outdated Show resolved Hide resolved
syncd/FlexCounter.cpp Outdated Show resolved Hide resolved
Mykola Faryma and others added 2 commits June 5, 2020 15:05
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
@kcudnik
Copy link
Collaborator

kcudnik commented Jun 8, 2020

please fix errors
15:45:08 FlexCounter.cpp:871:27: error: 'RIF_PLUGIN_FIELD' was not declared in this scope
15:45:08 else if (field == RIF_PLUGIN_FIELD)
15:45:08 ^~~~~~~~~~~~~~~~
15:45:08 FlexCounter.cpp: In member function 'void syncd::FlexCounter::runPlugins(swss::DBConnector&)':
15:45:08 FlexCounter.cpp:1506:24: error: 'db' was not declared in this scope
15:45:08 runRedisScript(db, sha, rifList, argv);
15:45:08 ^~
15:45:08 FlexCounter.cpp:1506:46: error: 'runRedisScript' was not declared in this scope
15:45:08 runRedisScript(db, sha, rifList, argv);

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
@lguohan lguohan merged commit db0b35a into sonic-net:master Jun 10, 2020
kktheballer pushed a commit to kktheballer/sonic-sairedis that referenced this pull request Aug 1, 2020
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants