[Mellanox] Resolve New Line Formatting Issues in syncd's sai.profile #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sure correct formatting
noaOrMlnx
approved these changes
Aug 12, 2024
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liat-grozovik
approved these changes
Sep 3, 2024
|
@kcudnik could you please help to review and merge? |
|
@kcudnik @saiarcot895 can you please help to merge? |
prgeor
approved these changes
Sep 25, 2024
kcudnik
approved these changes
Oct 2, 2024
|
Thanks, the |
bingwang-ms
added
Approved for 202405 Branch
and removed
Approved for 202405 Branch
labels
bingwang-ms
pushed a commit
to bingwang-ms/sonic-sairedis
that referenced
this pull request
Oct 15, 2024
…onic-net#1412) On Mellanox platforms, the /tmp/sai.profile file inside syncd might end up with invalid formatting after running the script modified by this PR, such as missing new lines after concatenation or redundant new lines. This PR aims to fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Mellanox platforms, the /tmp/sai.profile file inside syncd might end up with invalid formatting after running the script modified by this PR, such as missing new lines after concatenation or redundant new lines. This PR aims to fix that.